MirrorHub/forgejo
0
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-29 12:54:09 +01:00
Code Issues Projects Releases Packages Wiki Activity
forgejo/models/db
History
Eng Zer Jun 8b0aaa5f86
test: use T.TempDir to create temporary test directory (#21043) 
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
install Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
paginator Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
common.go Modify milestone search keywords to be case insensitive again (#20513) 2022-07-28 18:58:04 +02:00
consistency.go Move issues related files into models/issues (#19931) 2022-06-13 17:37:59 +08:00
context.go Fix various typos (#20338) 2022-07-12 23:32:37 +02:00
convert.go Refactor auth package (#17962) 2022-01-02 21:12:35 +08:00
engine.go Allow manager logging to set SQL (#20064) 2022-06-24 12:49:47 +02:00
engine_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
error.go Delete related PullAutoMerge and ReviewState on User/Repo Deletion (#19649) 2022-05-08 15:46:34 +02:00
index.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
iterate.go Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
list_options.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
log.go Allow manager logging to set SQL (#20064) 2022-06-24 12:49:47 +02:00
main_test.go Move tests as seperate sub packages to reduce duplicated file names (#19951) 2022-06-15 09:02:00 +02:00
name.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
search.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
sequence.go
sql_postgres_with_schema.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00