mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-09 11:21:19 +01:00
ddc709ff7f
When create a new issue or comment and paste/upload an attachment/image, it will not assign an issue id before submit. So if user give up the creating, the attachments will lost key feature and become dirty content. We don't know if we need to delete the attachment even if the repository deleted. This PR add a repo_id in attachment table so that even if a new upload attachment with no issue_id or release_id but should have repo_id. When deleting a repository, they could also be deleted. Co-authored-by: 6543 <6543@obermui.de>
128 lines
3.7 KiB
Go
128 lines
3.7 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestIncreaseDownloadCount(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
attachment, err := GetAttachmentByUUID("a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(0), attachment.DownloadCount)
|
|
|
|
// increase download count
|
|
err = attachment.IncreaseDownloadCount()
|
|
assert.NoError(t, err)
|
|
|
|
attachment, err = GetAttachmentByUUID("a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(1), attachment.DownloadCount)
|
|
}
|
|
|
|
func TestGetByCommentOrIssueID(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
// count of attachments from issue ID
|
|
attachments, err := GetAttachmentsByIssueID(1)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, attachments, 1)
|
|
|
|
attachments, err = GetAttachmentsByCommentID(1)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, attachments, 2)
|
|
}
|
|
|
|
func TestDeleteAttachments(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
count, err := DeleteAttachmentsByIssue(4, false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
|
|
count, err = DeleteAttachmentsByComment(2, false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
|
|
err = DeleteAttachment(&Attachment{ID: 8}, false)
|
|
assert.NoError(t, err)
|
|
|
|
attachment, err := GetAttachmentByUUID("a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a18")
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrAttachmentNotExist(err))
|
|
assert.Nil(t, attachment)
|
|
}
|
|
|
|
func TestGetAttachmentByID(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
attach, err := GetAttachmentByID(1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", attach.UUID)
|
|
}
|
|
|
|
func TestAttachment_DownloadURL(t *testing.T) {
|
|
attach := &Attachment{
|
|
UUID: "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11",
|
|
ID: 1,
|
|
}
|
|
assert.Equal(t, "https://try.gitea.io/attachments/a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", attach.DownloadURL())
|
|
}
|
|
|
|
func TestUpdateAttachment(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
attach, err := GetAttachmentByID(1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", attach.UUID)
|
|
|
|
attach.Name = "new_name"
|
|
assert.NoError(t, UpdateAttachment(attach))
|
|
|
|
AssertExistsAndLoadBean(t, &Attachment{Name: "new_name"})
|
|
}
|
|
|
|
func TestGetAttachmentsByUUIDs(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
attachList, err := GetAttachmentsByUUIDs(DefaultDBContext(), []string{"a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a17", "not-existing-uuid"})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, attachList, 2)
|
|
assert.Equal(t, "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", attachList[0].UUID)
|
|
assert.Equal(t, "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a17", attachList[1].UUID)
|
|
assert.Equal(t, int64(1), attachList[0].IssueID)
|
|
assert.Equal(t, int64(5), attachList[1].IssueID)
|
|
}
|
|
|
|
func TestLinkedRepository(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
testCases := []struct {
|
|
name string
|
|
attachID int64
|
|
expectedRepo *Repository
|
|
expectedUnitType UnitType
|
|
}{
|
|
{"LinkedIssue", 1, &Repository{ID: 1}, UnitTypeIssues},
|
|
{"LinkedComment", 3, &Repository{ID: 1}, UnitTypePullRequests},
|
|
{"LinkedRelease", 9, &Repository{ID: 1}, UnitTypeReleases},
|
|
{"Notlinked", 10, nil, -1},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
attach, err := GetAttachmentByID(tc.attachID)
|
|
assert.NoError(t, err)
|
|
repo, unitType, err := attach.LinkedRepository()
|
|
assert.NoError(t, err)
|
|
if tc.expectedRepo != nil {
|
|
assert.Equal(t, tc.expectedRepo.ID, repo.ID)
|
|
}
|
|
assert.Equal(t, tc.expectedUnitType, unitType)
|
|
})
|
|
}
|
|
}
|