forgejo/modules
zeripath 858c35b731
Ensure BlameReaders close at end of request (#12102)
#11716 reports multiple git blame processes hanging around
this was thought to be due to timeouts, however on closer look this
appears to be due to the Close() function of the BlameReader hanging
with a blocked stdout pipe.

This PR fixes this Close function to:

* Cancel the context of the cmd
* Close the StdoutReader - ensuring that the output pipe is closed

Further it makes the context of the `git blame` command a child of the
request context - ensuring that even if Close() is not called, on
cancellation of the Request the blame is command will also be cancelled.

Fixes #11716
Closes #11727

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-07-01 14:01:17 +01:00
..
analyze
auth Use google/uuid to instead satori/go.uuid (#11943) 2020-06-18 17:18:44 +08:00
avatar
base
cache
charset
context Fix typo (#12013) 2020-06-22 11:21:11 -04:00
convert Honor DEFAULT_PAGING_NUM for API (#11805) 2020-06-08 22:46:51 -04:00
cron
emoji
eventsource
generate
git Ensure BlameReaders close at end of request (#12102) 2020-07-01 14:01:17 +01:00
gitgraph
graceful
highlight Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
httplib
indexer Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
lfs
log
markup Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
metrics
migrations Use google/uuid to instead satori/go.uuid (#11943) 2020-06-18 17:18:44 +08:00
notification
options
password
pprof
private
process Only write to global gitconfig if necessary (#11876) 2020-06-13 17:47:31 -04:00
public Move fomantic and jQuery to main webpack bundle (#11997) 2020-06-27 22:59:56 -04:00
queue
recaptcha
references
repofiles Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
repository Global default branch setting (#11918) 2020-06-17 16:53:55 -04:00
secret
session
setting Global default branch setting (#11918) 2020-06-17 16:53:55 -04:00
ssh
structs API: Move AllowedReactions endpoint into GetGenneralUI endpoint + creat new swagger section settings (#11854) 2020-06-22 14:21:31 -04:00
sync
task
templates [UI] Sortable Tables Header By Click (#7980) 2020-06-24 23:23:05 +01:00
test
timeutil
upload
user
util
validation
webhook Fix comments webhook panic (#12046) 2020-06-24 23:39:43 -04:00