mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-02 16:29:06 +01:00
fdb1874ada
This commit adds a new flag, `--keep-labels`, to the runner registration CLI command. If this flag is present and the runner being registered already exists, it will prevent the runners' labels from being reset. In order to accomplish this, the signature of the `RegisterRunner` function from the `models/actions` package has been modified so that the labels argument can be nil. If it is, the part of the function that updates the record will not change the runner. Various tests have been added for this function, for the following cases: new runner with labels, new runner without label, existing runner with labels, existing runner without labels. The flag has been added to the CLI command, the action function has been updated to read the labels parameters through a separate function (`getLabels`), and test cases for this function have been added. <!-- Before submitting a PR, please read the contributing guidelines: https://codeberg.org/forgejo/forgejo/src/branch/forgejo/CONTRIBUTING.md --> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4610 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Emmanuel BENOÎT <tseeker@nocternity.net> Co-committed-by: Emmanuel BENOÎT <tseeker@nocternity.net>
88 lines
1.9 KiB
Go
88 lines
1.9 KiB
Go
// Copyright The Forgejo Authors.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package forgejo
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/services/context"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/urfave/cli/v2"
|
|
)
|
|
|
|
func TestActions_getLabels(t *testing.T) {
|
|
type testCase struct {
|
|
args []string
|
|
hasLabels bool
|
|
hasError bool
|
|
labels []string
|
|
}
|
|
type resultType struct {
|
|
labels *[]string
|
|
err error
|
|
}
|
|
|
|
cases := []testCase{
|
|
{
|
|
args: []string{"x"},
|
|
hasLabels: true,
|
|
hasError: false,
|
|
labels: []string{""},
|
|
}, {
|
|
args: []string{"x", "--labels", "a,b"},
|
|
hasLabels: true,
|
|
hasError: false,
|
|
labels: []string{"a", "b"},
|
|
}, {
|
|
args: []string{"x", "--keep-labels"},
|
|
hasLabels: false,
|
|
hasError: false,
|
|
}, {
|
|
args: []string{"x", "--keep-labels", "--labels", "a,b"},
|
|
hasLabels: false,
|
|
hasError: true,
|
|
}, {
|
|
// this edge-case exists because that's what actually happens
|
|
// when no '--labels ...' options are present
|
|
args: []string{"x", "--keep-labels", "--labels", ""},
|
|
hasLabels: false,
|
|
hasError: false,
|
|
},
|
|
}
|
|
|
|
flags := SubcmdActionsRegister(context.Context{}).Flags
|
|
for _, c := range cases {
|
|
t.Run(fmt.Sprintf("args: %v", c.args), func(t *testing.T) {
|
|
// Create a copy of command to test
|
|
var result *resultType
|
|
app := cli.NewApp()
|
|
app.Flags = flags
|
|
app.Action = func(ctx *cli.Context) error {
|
|
labels, err := getLabels(ctx)
|
|
result = &resultType{labels, err}
|
|
return nil
|
|
}
|
|
|
|
// Run it
|
|
_ = app.Run(c.args)
|
|
|
|
// Test the results
|
|
require.NotNil(t, result)
|
|
if c.hasLabels {
|
|
assert.NotNil(t, result.labels)
|
|
assert.Equal(t, c.labels, *result.labels)
|
|
} else {
|
|
assert.Nil(t, result.labels)
|
|
}
|
|
if c.hasError {
|
|
assert.NotNil(t, result.err)
|
|
} else {
|
|
assert.Nil(t, result.err)
|
|
}
|
|
})
|
|
}
|
|
}
|