mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-30 03:27:44 +01:00
67fa52dedb
The previous commit laid out the foundation of the quota engine, this one builds on top of it, and implements the actual enforcement. Enforcement happens at the route decoration level, whenever possible. In case of the API, when over quota, a 413 error is returned, with an appropriate JSON payload. In case of web routes, a 413 HTML page is rendered with similar information. This implementation is for a **soft quota**: quota usage is checked before an operation is to be performed, and the operation is *only* denied if the user is already over quota. This makes it possible to go over quota, but has the significant advantage of being practically implementable within the current Forgejo architecture. The goal of enforcement is to deny actions that can make the user go over quota, and allow the rest. As such, deleting things should - in almost all cases - be possible. A prime exemption is deleting files via the web ui: that creates a new commit, which in turn increases repo size, thus, is denied if the user is over quota. Limitations ----------- Because we generally work at a route decorator level, and rarely look *into* the operation itself, `size:repos:public` and `size:repos:private` are not enforced at this level, the engine enforces against `size:repos:all`. This will be improved in the future. AGit does not play very well with this system, because AGit PRs count toward the repo they're opened against, while in the GitHub-style fork + pull model, it counts against the fork. This too, can be improved in the future. There's very little done on the UI side to guard against going over quota. What this patch implements, is enforcement, not prevention. The UI will still let you *try* operations that *will* result in a denial. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
146 lines
3.7 KiB
Go
146 lines
3.7 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package mirror
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
quota_model "code.gitea.io/gitea/models/quota"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/modules/graceful"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/queue"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
)
|
|
|
|
// doMirrorSync causes this request to mirror itself
|
|
func doMirrorSync(ctx context.Context, req *SyncRequest) {
|
|
if req.ReferenceID == 0 {
|
|
log.Warn("Skipping mirror sync request, no mirror ID was specified")
|
|
return
|
|
}
|
|
switch req.Type {
|
|
case PushMirrorType:
|
|
_ = SyncPushMirror(ctx, req.ReferenceID)
|
|
case PullMirrorType:
|
|
_ = SyncPullMirror(ctx, req.ReferenceID)
|
|
default:
|
|
log.Error("Unknown Request type in queue: %v for MirrorID[%d]", req.Type, req.ReferenceID)
|
|
}
|
|
}
|
|
|
|
var errLimit = fmt.Errorf("reached limit")
|
|
|
|
// Update checks and updates mirror repositories.
|
|
func Update(ctx context.Context, pullLimit, pushLimit int) error {
|
|
if !setting.Mirror.Enabled {
|
|
log.Warn("Mirror feature disabled, but cron job enabled: skip update")
|
|
return nil
|
|
}
|
|
log.Trace("Doing: Update")
|
|
|
|
handler := func(bean any) error {
|
|
var repo *repo_model.Repository
|
|
var mirrorType SyncType
|
|
var referenceID int64
|
|
|
|
if m, ok := bean.(*repo_model.Mirror); ok {
|
|
if m.GetRepository(ctx) == nil {
|
|
log.Error("Disconnected mirror found: %d", m.ID)
|
|
return nil
|
|
}
|
|
repo = m.Repo
|
|
mirrorType = PullMirrorType
|
|
referenceID = m.RepoID
|
|
} else if m, ok := bean.(*repo_model.PushMirror); ok {
|
|
if m.GetRepository(ctx) == nil {
|
|
log.Error("Disconnected push-mirror found: %d", m.ID)
|
|
return nil
|
|
}
|
|
repo = m.Repo
|
|
mirrorType = PushMirrorType
|
|
referenceID = m.ID
|
|
} else {
|
|
log.Error("Unknown bean: %v", bean)
|
|
return nil
|
|
}
|
|
|
|
// Check we've not been cancelled
|
|
select {
|
|
case <-ctx.Done():
|
|
return fmt.Errorf("aborted")
|
|
default:
|
|
}
|
|
|
|
// Check if the repo's owner is over quota, for pull mirrors
|
|
if mirrorType == PullMirrorType {
|
|
ok, err := quota_model.EvaluateForUser(ctx, repo.OwnerID, quota_model.LimitSubjectSizeReposAll)
|
|
if err != nil {
|
|
log.Error("quota_model.EvaluateForUser: %v", err)
|
|
return err
|
|
}
|
|
if !ok {
|
|
log.Trace("Owner quota exceeded for %-v, not syncing", repo)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// Push to the Queue
|
|
if err := PushToQueue(mirrorType, referenceID); err != nil {
|
|
if err == queue.ErrAlreadyInQueue {
|
|
if mirrorType == PushMirrorType {
|
|
log.Trace("PushMirrors for %-v already queued for sync", repo)
|
|
} else {
|
|
log.Trace("PullMirrors for %-v already queued for sync", repo)
|
|
}
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
pullMirrorsRequested := 0
|
|
if pullLimit != 0 {
|
|
if err := repo_model.MirrorsIterate(ctx, pullLimit, func(_ int, bean any) error {
|
|
if err := handler(bean); err != nil {
|
|
return err
|
|
}
|
|
pullMirrorsRequested++
|
|
return nil
|
|
}); err != nil && err != errLimit {
|
|
log.Error("MirrorsIterate: %v", err)
|
|
return err
|
|
}
|
|
}
|
|
|
|
pushMirrorsRequested := 0
|
|
if pushLimit != 0 {
|
|
if err := repo_model.PushMirrorsIterate(ctx, pushLimit, func(idx int, bean any) error {
|
|
if err := handler(bean); err != nil {
|
|
return err
|
|
}
|
|
pushMirrorsRequested++
|
|
return nil
|
|
}); err != nil && err != errLimit {
|
|
log.Error("PushMirrorsIterate: %v", err)
|
|
return err
|
|
}
|
|
}
|
|
log.Trace("Finished: Update: %d pull mirrors and %d push mirrors queued", pullMirrorsRequested, pushMirrorsRequested)
|
|
return nil
|
|
}
|
|
|
|
func queueHandler(items ...*SyncRequest) []*SyncRequest {
|
|
for _, req := range items {
|
|
doMirrorSync(graceful.GetManager().ShutdownContext(), req)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// InitSyncMirrors initializes a go routine to sync the mirrors
|
|
func InitSyncMirrors() {
|
|
StartSyncMirrors(queueHandler)
|
|
}
|