Earl Warren 603a44edf0 [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments ... Refs: https://codeberg.org/forgejo/forgejo/issues/2109 (cherry picked from commit 8b4ba3dce7) (cherry picked from commit 196edea0f9) [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review If a comment already exists in a review, the comment is added. If it is the first comment added to a review, it will implicitly create a new review instead of adding to the existing one. The pull_service.CreateCodeComment function is responsibe for this behavior and it will defer to createCodeComment once the review is determined, either because it was found or because it was created. Rename createCodeComment into CreateCodeCommentKnownReviewID to expose it and change the API endpoint to use it instead. Since the review is provided by the user and verified to exist already, there is no need for the logic implemented by CreateCodeComment. The tests are modified to remove the initial comment from the fixture because it was creating the false positive. I was verified to fail without this fix. (cherry picked from commit 6a555996dc) (cherry picked from commit b173a0ccee) (cherry picked from commit 838ab9740a)		2024-02-05 16:09:42 +01:00
..
check.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
check_test.go	Replace assert.Fail with assert.FailNow (#27578)	2023-10-11 11:02:24 +00:00
comment.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
commit_status.go	[GITEA] Use existing error functionality	2024-02-05 16:09:40 +01:00
edits.go
lfs.go	Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220)	2023-12-07 15:27:36 +08:00
main_test.go	make writing main test easier (#27270)	2023-09-28 01:38:53 +00:00
merge.go	Abstract hash function usage (#28138)	2023-12-13 21:02:00 +00:00
merge_merge.go
merge_prepare.go
merge_rebase.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
merge_squash.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
merge_test.go
patch.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
patch_unmerged.go
pull.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
pull_test.go	Simplify how git repositories are opened (#28937)	2024-01-27 21:09:51 +01:00
review.go	[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments	2024-02-05 16:09:42 +01:00
temp_repo.go	Adjust object format interface (#28469)	2023-12-17 11:56:08 +00:00
update.go	Sync branches into databases (#22743)	2023-06-29 10:03:20 +00:00
update_rebase.go