mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-05 01:39:13 +01:00
d5fa2e7510
Fix #22581 TLDR: #18446 made a mess with ForeignIndex and triggered a design flaw/bug of #16356, then a quick patch #21271 helped #18446, then the the bug was re-triggered by #21721 . Related: * #16356 * BasicIssueContext https://github.com/go-gitea/gitea/pull/16356/files#diff-7938eb670d42a5ead6b08121e16aa4537a4d716c1cf37923c70470020fb9d036R16-R27 * #18446 * If some issues were dumped without ForeignIndex, then they would be imported as ForeignIndex=0 https://github.com/go-gitea/gitea/pull/18446/files#diff-1624a3e715d8fc70edf2db1630642b7d6517f8c359cc69d58c3958b34ba4ce5eR38-R39 * #21271 * It patched the above bug (somewhat), made the issues without ForeignIndex could have the same value as LocalIndex * #21721 * It re-triggered the zero-ForeignIndex bug. ps: I am not sure whether the changes in `GetForeignIndex` are ideal (at least, now it has almost the same behavior as BasicIssueContext in #16356), it's just a quick fix. Feel free to edit on this PR directly or replace it. Co-authored-by: zeripath <art27@cantab.net>
67 lines
2.2 KiB
Go
67 lines
2.2 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package migration
|
|
|
|
import "time"
|
|
|
|
// Reviewable can be reviewed
|
|
type Reviewable interface {
|
|
GetLocalIndex() int64
|
|
|
|
// GetForeignIndex presents the foreign index, which could be misused:
|
|
// For example, if there are 2 Gitea sites: site-A exports a dataset, then site-B imports it:
|
|
// * if site-A exports files by using its LocalIndex
|
|
// * from site-A's view, LocalIndex is site-A's IssueIndex while ForeignIndex is site-B's IssueIndex
|
|
// * but from site-B's view, LocalIndex is site-B's IssueIndex while ForeignIndex is site-A's IssueIndex
|
|
//
|
|
// So the exporting/importing must be paired, but the meaning of them looks confusing then:
|
|
// * either site-A and site-B both use LocalIndex during dumping/restoring
|
|
// * or site-A and site-B both use ForeignIndex
|
|
GetForeignIndex() int64
|
|
}
|
|
|
|
// enumerate all review states
|
|
const (
|
|
ReviewStatePending = "PENDING"
|
|
ReviewStateApproved = "APPROVED"
|
|
ReviewStateChangesRequested = "CHANGES_REQUESTED"
|
|
ReviewStateCommented = "COMMENTED"
|
|
ReviewStateRequestReview = "REQUEST_REVIEW"
|
|
)
|
|
|
|
// Review is a standard review information
|
|
type Review struct {
|
|
ID int64
|
|
IssueIndex int64 `yaml:"issue_index"`
|
|
ReviewerID int64 `yaml:"reviewer_id"`
|
|
ReviewerName string `yaml:"reviewer_name"`
|
|
Official bool
|
|
CommitID string `yaml:"commit_id"`
|
|
Content string
|
|
CreatedAt time.Time `yaml:"created_at"`
|
|
State string // PENDING, APPROVED, REQUEST_CHANGES, or COMMENT
|
|
Comments []*ReviewComment
|
|
}
|
|
|
|
// GetExternalName ExternalUserMigrated interface
|
|
func (r *Review) GetExternalName() string { return r.ReviewerName }
|
|
|
|
// GetExternalID ExternalUserMigrated interface
|
|
func (r *Review) GetExternalID() int64 { return r.ReviewerID }
|
|
|
|
// ReviewComment represents a review comment
|
|
type ReviewComment struct {
|
|
ID int64
|
|
InReplyTo int64 `yaml:"in_reply_to"`
|
|
Content string
|
|
TreePath string `yaml:"tree_path"`
|
|
DiffHunk string `yaml:"diff_hunk"`
|
|
Position int
|
|
Line int
|
|
CommitID string `yaml:"commit_id"`
|
|
PosterID int64 `yaml:"poster_id"`
|
|
Reactions []*Reaction
|
|
CreatedAt time.Time `yaml:"created_at"`
|
|
UpdatedAt time.Time `yaml:"updated_at"`
|
|
}
|