mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-09-21 17:38:58 +02:00
c9e402afdc
Modifies forms: - (new) org team - (new) repo webhook - (new) repo protected branch The forms are not completely rewritten to semantic HTML yet. The focus of this change was on standard elements, some custom solutions were left untouched for now. - swaps the order fo permission radio buttons as per https://codeberg.org/forgejo/forgejo/issues/4983 - uses fieldsets to group related inputs - ensures consistent styling across forms - can be improved later, e.g. using horizontal lines between sections - fixes: previous font size of labels was smaller than the font size of the help text - help text are now part of the label, clicking them now also activates the input - drop unused CSS (no required checkboxes in grouped class remain) - playwright testing: - move login boilerplate to utils - automated form accessibility checking - allow defining the scope, because legacy parts of the forms are not yet accessible - assert some CSS properties that should not be overriden - the Makefile adjustment was necessary, because eslint scanned some internal files in the tests/e2e/reports directory
16 lines
688 B
JavaScript
16 lines
688 B
JavaScript
import {expect} from '@playwright/test';
|
|
import AxeBuilder from '@axe-core/playwright';
|
|
|
|
export async function validate_form({page}, scope) {
|
|
scope ??= 'form';
|
|
const accessibilityScanResults = await new AxeBuilder({page}).include(scope).analyze();
|
|
expect(accessibilityScanResults.violations).toEqual([]);
|
|
|
|
// assert CSS properties that needed to be overriden for forms (ensure they remain active)
|
|
const boxes = page.getByRole('checkbox').or(page.getByRole('radio'));
|
|
for (const b of await boxes.all()) {
|
|
await expect(b).toHaveCSS('margin-left', '0px');
|
|
await expect(b).toHaveCSS('margin-top', '0px');
|
|
await expect(b).toHaveCSS('vertical-align', 'baseline');
|
|
}
|
|
}
|