mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-02 13:39:33 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M) |
||
|---|---|---|
| .. | ||
| main_test.go | ||
| v280.go | ||
| v281.go | ||
| v282.go | ||
| v283.go | ||
| v283_test.go | ||
| v284.go | ||
| v285.go | ||
| v286.go | ||
| v286_test.go | ||
| v287.go | ||
| v288.go | ||
| v289.go | ||
| v290.go | ||
| v290_test.go | ||
| v291.go | ||
| v292.go | ||
| v293.go | ||
| v293_test.go | ||
| v294.go | ||
| v294_test.go | ||
| v295.go | ||
| v296.go | ||
| v298.go | ||