forgejo/models/activities
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
action.go Use absolute links in feeds (#21229) 2022-09-21 16:51:42 -04:00
action_list.go Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
action_test.go Use absolute links in feeds (#21229) 2022-09-21 16:51:42 -04:00
main_test.go
notification.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
notification_test.go
repo_activity.go Fix various typos (#21103) 2022-09-07 14:40:36 -04:00
statistic.go
user_heatmap.go
user_heatmap_test.go