forgejo/models/migrations
Henry Goodman ee8f3e09f8
Allow force push to protected branches (#28086) (migration v300)
Fixes #22722

Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

branch `test` being a protected branch:

![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 12cb1d2998f2a307713ce979f8d585711e92061c)
2024-08-04 18:24:10 +02:00
..
base [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
fixtures Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (#30894) 2024-05-12 20:03:10 +02:00
test Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_6 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_7
v1_8
v1_9 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_10
v1_11 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_12
v1_13
v1_14 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_15 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_16 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_17 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_18 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_19 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_20 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_21 Upgrade xorm to v1.3.9 and improve some migrations Sync (#29899) 2024-07-22 15:44:13 +02:00
v1_22 Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
v1_23 Allow force push to protected branches (#28086) (migration v300) 2024-08-04 18:24:10 +02:00
migrations.go Allow force push to protected branches (#28086) (migration v300) 2024-08-04 18:24:10 +02:00