zeripath 06f968d662 Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051) ... Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2022-09-06 07:54:47 +01:00
..
archiver	Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051)	2022-09-06 07:54:47 +01:00
files	Remove legacy git code (ver < 2.0), fine tune markup tests (#19930)	2022-06-16 23:47:44 +08:00
adopt.go
adopt_test.go
avatar.go	Add migrate repo archiver and packages storage support on command line (#20757) (#20806)	2022-08-18 09:27:56 +08:00
avatar_test.go
branch.go
cache.go
check.go
fork.go
fork_test.go
hooks.go
main_test.go
push.go
repository.go	Move issues related files into models/issues (#19931)	2022-06-13 17:37:59 +08:00
repository_test.go
review.go
review_test.go
template.go	Check issue labels slice length before calling xorm Insert(#20655) (#20836)	2022-08-17 23:36:56 +01:00
transfer.go
transfer_test.go