MirrorHub/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-06 14:19:03 +01:00
Code Issues Releases Wiki Activity

Remove jQuery AJAX from repo collaborator mode dropdown (#29371)

Browse source 
- Removed all jQuery AJAX calls and replaced with our fetch wrapper
- Tested the repo collaborator mode dropdown functionality and it works
as before

# Demo using `fetch` instead of jQuery AJAX

![action](https://github.com/go-gitea/gitea/assets/20454870/04466629-19b2-4469-9231-38820ee13c36)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
Yarden Shoham 2024-02-25 01:08:51 +02:00 committed by GitHub
parent 10c7996b5a
commit 15d071f4f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
web_src/js/features/repo-settings.js
View file

@ -2,6 +2,7 @@ import $ from 'jquery';
import {minimatch} from 'minimatch'; import {minimatch} from 'minimatch';
import {createMonaco} from './codeeditor.js'; import {createMonaco} from './codeeditor.js';
import {onInputDebounce, toggleElem} from '../utils/dom.js'; import {onInputDebounce, toggleElem} from '../utils/dom.js';
import {POST} from '../modules/fetch.js';
const {appSubUrl, csrfToken} = window.config; const {appSubUrl, csrfToken} = window.config;
@ -11,18 +12,19 @@ export function initRepoSettingsCollaboration() {
const $dropdown = $(e); const $dropdown = $(e);
const $text = $dropdown.find('> .text'); const $text = $dropdown.find('> .text');
$dropdown.dropdown({ $dropdown.dropdown({
action(_text, value) { async action(_text, value) {
const lastValue = $dropdown.attr('data-last-value'); const lastValue = $dropdown.attr('data-last-value');
$.post($dropdown.attr('data-url'), { try {
_csrf: csrfToken,
uid: $dropdown.attr('data-uid'),
mode: value,
}).fail(() => {
$text.text('(error)'); // prevent from misleading users when error occurs
$dropdown.attr('data-last-value', lastValue);
});
$dropdown.attr('data-last-value', value); $dropdown.attr('data-last-value', value);
$dropdown.dropdown('hide'); $dropdown.dropdown('hide');
const data = new FormData();
data.append('uid', $dropdown.attr('data-uid'));
data.append('mode', value);
await POST($dropdown.attr('data-url'), {data});
} catch {
$text.text('(error)'); // prevent from misleading users when error occurs
$dropdown.attr('data-last-value', lastValue);
}
}, },
onChange(_value, text, _$choice) { onChange(_value, text, _$choice) {
$text.text(text); // update the text when using keyboard navigating $text.text(text); // update the text when using keyboard navigating