mirror of
https://github.com/go-gitea/gitea
synced 2024-11-18 07:52:03 +01:00
New review approvals shouldn't require a message (#8991)
* New approvals don't require content Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix edge-bug Signed-off-by: jolheiser <john.olheiser@gmail.com>
This commit is contained in:
parent
ae36ed7ecb
commit
4b5ebb93e4
1 changed files with 2 additions and 2 deletions
|
@ -254,7 +254,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content strin
|
|||
return nil, nil, err
|
||||
}
|
||||
|
||||
if len(strings.TrimSpace(content)) == 0 {
|
||||
if reviewType != ReviewTypeApprove && len(strings.TrimSpace(content)) == 0 {
|
||||
return nil, nil, ContentEmptyErr{}
|
||||
}
|
||||
|
||||
|
@ -272,7 +272,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content strin
|
|||
if err := review.loadCodeComments(sess); err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
if len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
|
||||
if reviewType != ReviewTypeApprove && len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
|
||||
return nil, nil, ContentEmptyErr{}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue