From 54af3c90c72d48031d6e666e708f24115b64703b Mon Sep 17 00:00:00 2001
From: James Lakin <jamesorlakin@users.noreply.github.com>
Date: Tue, 11 Feb 2020 20:40:47 +0000
Subject: [PATCH] Fix issue sidebar menus having an infinite height (#10239)

* Revert "Limit label list height on edit issue page"

* Fix issue sidebar menus having an infinite height
---
 templates/repo/issue/view_content/sidebar.tmpl | 2 +-
 web_src/less/_repository.less                  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl
index a9a4035594..d6fe28a074 100644
--- a/templates/repo/issue/view_content/sidebar.tmpl
+++ b/templates/repo/issue/view_content/sidebar.tmpl
@@ -7,7 +7,7 @@
 				<strong>{{.i18n.Tr "repo.issues.new.labels"}}</strong>
 				{{svg "octicon-gear" 16}}
 			</span>
-			<div class="filter menu labels" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/labels">
+			<div class="filter menu" data-action="update" data-issue-id="{{$.Issue.ID}}" data-update-url="{{$.RepoLink}}/issues/labels">
 				<div class="no-select item">{{.i18n.Tr "repo.issues.new.clear_labels"}}</div>
 				{{range .Labels}}
 					<a class="{{if .IsChecked}}checked{{end}} item has-emoji" href="#" data-id="{{.ID}}" data-id-selector="#label_{{.ID}}"><span class="octicon-check {{if not .IsChecked}}invisible{{end}}">{{svg "octicon-check" 16}}</span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name}}
diff --git a/web_src/less/_repository.less b/web_src/less/_repository.less
index bd2449ba1e..2e5ae08088 100644
--- a/web_src/less/_repository.less
+++ b/web_src/less/_repository.less
@@ -83,6 +83,7 @@
     .metas {
         .menu {
             overflow-x: auto;
+            max-height: 300px;
         }
 
         .ui.list {
@@ -152,8 +153,6 @@
         }
 
         &.labels {
-            max-height: 300px;
-
             .label-filter .menu .info {
                 display: inline-block;
                 padding: 9px 7px 7px 7px;