mirror of
https://github.com/go-gitea/gitea
synced 2024-08-26 12:05:31 +02:00
Warn that DISABLE_QUERY_AUTH_TOKEN
is false only if it's explicitly defined (#28783)
So we don't warn on default behavior - Fixes https://github.com/go-gitea/gitea/issues/28758 - Follows https://github.com/go-gitea/gitea/pull/28390 Signed-off-by: Yarden Shoham <git@yardenshoham.com>
This commit is contained in:
parent
fa8c3beb26
commit
5a7bacb005
1 changed files with 4 additions and 1 deletions
|
@ -159,10 +159,13 @@ func loadSecurityFrom(rootCfg ConfigProvider) {
|
|||
}
|
||||
}
|
||||
|
||||
sectionHasDisableQueryAuthToken := sec.HasKey("DISABLE_QUERY_AUTH_TOKEN")
|
||||
|
||||
// TODO: default value should be true in future releases
|
||||
DisableQueryAuthToken = sec.Key("DISABLE_QUERY_AUTH_TOKEN").MustBool(false)
|
||||
|
||||
if !DisableQueryAuthToken {
|
||||
// warn if the setting is set to false explicitly
|
||||
if sectionHasDisableQueryAuthToken && !DisableQueryAuthToken {
|
||||
log.Warn("Enabling Query API Auth tokens is not recommended. DISABLE_QUERY_AUTH_TOKEN will default to true in gitea 1.23 and will be removed in gitea 1.24.")
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue