#1064: X-Gogs-Event header is empty

gogs.go

@@ -17,7 +17,7 @@ import (
 	"github.com/gogits/gogs/modules/setting"
 )
 
-const APP_VER = "0.5.16.0317 Beta"
+const APP_VER = "0.5.16.0318 Beta"
 
 func init() {
 	runtime.GOMAXPROCS(runtime.NumCPU())

models/action.go

@@ -417,32 +417,28 @@ func CommitRepoAction(userId, repoUserId int64, userName, actEmail string,
 			continue
 		}
 
+		var payload BasePayload
 		switch w.HookTaskType {
 		case SLACK:
-			{
+			s, err := GetSlackPayload(p, w.Meta)
-				s, err := GetSlackPayload(p, w.Meta)
+			if err != nil {
-				if err != nil {
+				return errors.New("action.GetSlackPayload: " + err.Error())
-					return errors.New("action.GetSlackPayload: " + err.Error())
-				}
-				CreateHookTask(&HookTask{
-					Type:        w.HookTaskType,
-					Url:         w.Url,
-					BasePayload: s,
-					ContentType: w.ContentType,
-					IsSsl:       w.IsSsl,
-				})
 			}
+			payload = s
 		default:
-			{
+			payload = p
-				p.Secret = w.Secret
+			p.Secret = w.Secret
-				CreateHookTask(&HookTask{
+		}
-					Type:        w.HookTaskType,
+
-					Url:         w.Url,
+		if err = CreateHookTask(&HookTask{
-					BasePayload: p,
+			Type:        w.HookTaskType,
-					ContentType: w.ContentType,
+			Url:         w.Url,
-					IsSsl:       w.IsSsl,
+			BasePayload: payload,
-				})
+			ContentType: w.ContentType,
-			}
+			EventType:   HOOK_EVENT_PUSH,
+			IsSsl:       w.IsSsl,
+		}); err != nil {
+			return fmt.Errorf("CreateHookTask: %v", err)
 		}
 	}
 

models/webhook.go

@@ -205,7 +205,7 @@ func IsValidHookTaskType(name string) bool {
 type HookEventType string
 
 const (
-	PUSH HookEventType = "push"
+	HOOK_EVENT_PUSH HookEventType = "push"
 )
 
 // FIXME: just use go-gogs-client structs maybe?

templates/.VERSION

@@ -1 +1 @@
-0.5.16.0317 Beta
+0.5.16.0318 Beta