#2954 use text/plain as default email content format

README.md

@@ -3,7 +3,7 @@ Gogs - Go Git Service [![Build Status](https://travis-ci.org/gogits/gogs.svg?bra
 
 ![](https://github.com/gogits/gogs/blob/master/public/img/gogs-large-resize.png?raw=true)
 
-##### Current version: 0.9.28
+##### Current version: 0.9.29
 
 | Web | UI  | Preview  |
 |:-------------:|:-------:|:-------:|

conf/app.ini

@@ -185,6 +185,8 @@ FROM =
 ; Mailer user name and password
 USER =
 PASSWD =
+; Use text/html as alternative format of content
+ENABLE_HTML_ALTERNATIVE = false
 
 [cache]
 ; Either "memory", "redis", or "memcache", default is "memory"

gogs.go

@@ -17,7 +17,7 @@ import (
 	"github.com/gogits/gogs/modules/setting"
 )
 
-const APP_VER = "0.9.28.0527"
+const APP_VER = "0.9.29.0530"
 
 func init() {
 	runtime.GOMAXPROCS(runtime.NumCPU())

modules/mailer/mailer.go

@@ -14,11 +14,11 @@ import (
 	"strings"
 	"time"
 
+	"github.com/jaytaylor/html2text"
 	"gopkg.in/gomail.v2"
 
 	"github.com/gogits/gogs/modules/log"
 	"github.com/gogits/gogs/modules/setting"
-	"github.com/jaytaylor/html2text"
 )
 
 type Message struct {
@@ -27,20 +27,24 @@ type Message struct {
 }
 
 // NewMessageFrom creates new mail message object with custom From header.
-func NewMessageFrom(to []string, from, subject, htmlbody string) *Message {
+func NewMessageFrom(to []string, from, subject, htmlBody string) *Message {
 	msg := gomail.NewMessage()
 	msg.SetHeader("From", from)
 	msg.SetHeader("To", to...)
 	msg.SetHeader("Subject", subject)
 	msg.SetDateHeader("Date", time.Now())
-	body, err := html2text.FromString(htmlbody)
+
+	body, err := html2text.FromString(htmlBody)
 	if err != nil {
-		// TODO: report error ?
-		msg.SetBody("text/html", htmlbody)
+		log.Error(4, "html2text.FromString: %v", err)
+		msg.SetBody("text/html", htmlBody)
+		msg.AddAlternative("text/html", htmlBody)
 	} else {
 		msg.SetBody("text/plain", body)
-		// TODO: avoid this (use a configuration switch?)
-		msg.AddAlternative("text/html", htmlbody)
+	}
+
+	if setting.MailService.EnableHTMLAlternative {
+		msg.AddAlternative("text/html", htmlBody)
 	}
 
 	return &Message{

modules/setting/setting.go

@@ -622,6 +622,7 @@ type Mailer struct {
 	SkipVerify            bool
 	UseCertificate        bool
 	CertFile, KeyFile     string
+	EnableHTMLAlternative bool
 }
 
 var (
@@ -647,6 +648,7 @@ func newMailService() {
 		UseCertificate:        sec.Key("USE_CERTIFICATE").MustBool(),
 		CertFile:              sec.Key("CERT_FILE").String(),
 		KeyFile:               sec.Key("KEY_FILE").String(),
+		EnableHTMLAlternative: sec.Key("ENABLE_HTML_ALTERNATIVE").MustBool(),
 	}
 	MailService.From = sec.Key("FROM").MustString(MailService.User)
 	log.Info("Mail Service Enabled")

templates/.VERSION

@@ -1 +1 @@
-0.9.28.0527
+0.9.29.0530