0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-24 15:04:29 +01:00
gitea/services/migrations
Nanguan Lin 49b98e45bc
Fix migration panic due to an empty review comment diff (#28334)
Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)
2023-12-05 08:29:43 +00:00
..
codebase.go
codebase_test.go
common.go
dump.go
error.go
git.go
gitbucket.go
gitea_downloader.go Fix DownloadFunc when migrating releases (#27887) 2023-11-03 15:56:53 +08:00
gitea_downloader_test.go
gitea_uploader.go Fix migration panic due to an empty review comment diff (#28334) 2023-12-05 08:29:43 +00:00
gitea_uploader_test.go
github.go
github_test.go
gitlab.go Fix DownloadFunc when migrating releases (#27887) 2023-11-03 15:56:53 +08:00
gitlab_test.go
gogs.go
gogs_test.go
http_client.go
main_test.go
migrate.go
migrate_test.go
onedev.go
onedev_test.go
restore.go
update.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00