0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-28 08:34:37 +01:00
gitea/modules
zeripath c58bc4bf80
Prevent timer leaks in Workerpool and others (#11333)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-08 16:46:05 +01:00
..
analyze
auth
avatar
base
cache
charset
context api.Context.NotFound(...) should tolerate nil (#11288) 2020-05-05 21:52:13 +03:00
convert API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
cron
emoji
eventsource Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
generate
git Manage port in submodule refurl (#11305) 2020-05-07 11:25:52 -03:00
gitgraph
graceful
highlight
httplib
indexer
lfs
log
markup Restore checkbox rendering and prevent poor sanitization of spans (#11277) 2020-05-03 17:17:24 -03:00
metrics
migrations Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
notification Add NotifySyncPushCommits to indexer notifier (#11309) 2020-05-08 15:58:40 +01:00
options
password
pprof
private
process
public
queue Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
recaptcha
references
repofiles
repository
secret
session
setting Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
ssh
structs API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
sync
task
templates Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
test
timeutil
upload
user
util Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
validation
webhook