0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-09-12 04:09:41 +02:00
gitea/services
Eng Zer Jun 13d5d2e711
Remove redundant len check around loop (#27464)
This pull request is a minor code cleanup.

From the Go specification (https://go.dev/ref/spec#For_range):

> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.

---

At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-10-06 14:49:37 +08:00
..
actions Make Actions tasks/jobs timeouts configurable by the user (#27400) 2023-10-02 23:09:26 +02:00
agit
asymkey make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
attachment Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
auth Fix ldap admin privileges update bug (#27051) 2023-10-01 11:32:12 +00:00
automerge
context Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
convert Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
cron More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
externalaccount More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Add support for forking single branch (#25821) 2023-09-29 09:48:39 +08:00
gitdiff Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
indexer
issue Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
lfs
mailer Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
markup make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrations Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
mirror Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
notify
org make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
packages Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
pull Remove redundant len check around loop (#27464) 2023-10-06 14:49:37 +08:00
release Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
repository Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
secrets
task Fix unexpected context canceled when migrating repository (#27368) 2023-10-01 12:04:35 +00:00
uinotification More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
user Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
webhook make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
wiki Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00