0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 23:14:36 +01:00
gitea/modules/markup
Gary Kim 7eed11e5e9 Check commit message hashes before making links (#7713)
* Check commit message hashes before making links

Previously, when formatting commit messages, anything
that looked like SHA1 hashes was turned into a link
using regex. This meant that certain phrases or numbers
such as `777777` or `deadbeef` could be recognized as a commit
even if the repository has no commit with those hashes.

This change will make it so that anything that looks
like a SHA1 hash using regex will then also be checked
to ensure that there is a commit in the repository
with that hash before making a link.

Signed-off-by: Gary Kim <gary@garykim.dev>

* Use gogit to check if commit exists

This commit modifies the commit hash check
in the render for commit messages to use
gogit for better performance.

Signed-off-by: Gary Kim <gary@garykim.dev>

* Make code cleaner

Signed-off-by: Gary Kim <gary@garykim.dev>

* Use rev-parse to check if commit exists

Signed-off-by: Gary Kim <gary@garykim.dev>

* Add and modify tests for checking hashes in html link rendering

Signed-off-by: Gary Kim <gary@garykim.dev>

* Return error in sha1CurrentPatternProcessor

Co-Authored-By: mrsdizzie <info@mrsdizzie.com>

* Import Gitea log module

Signed-off-by: Gary Kim <gary@garykim.dev>

* Revert "Return error in sha1CurrentPatternProcessor"

This reverts commit 28f561cac4.

Signed-off-by: Gary Kim <gary@garykim.dev>

* Add debug logging to sha1CurrentPatternProcessor

This will log errors by the git command run in
sha1CurrentPatternProcessor if the error is one
that was unexpected.

Signed-off-by: Gary Kim <gary@garykim.dev>
2019-08-14 16:04:55 +08:00
..
csv
external
markdown Check commit message hashes before making links (#7713) 2019-08-14 16:04:55 +08:00
orgmode
html.go Check commit message hashes before making links (#7713) 2019-08-14 16:04:55 +08:00
html_internal_test.go fix hljs unintenionally highlighting commit links (#7244) 2019-06-18 18:31:31 -04:00
html_test.go Check commit message hashes before making links (#7713) 2019-08-14 16:04:55 +08:00
markup.go Fix wrong init dependency on markup extensions (#7038) 2019-05-25 18:15:39 +01:00
markup_test.go
sanitizer.go
sanitizer_test.go