0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-09-21 08:39:05 +02:00
No description https://gitea.io
Find a file
Giteabot 1cf8f69b38
Avoid returning without written ctx when posting PR (#31843) (#31848)
Backport #31843 by @wolfogre

Fix #31625.

If `pull_service.NewPullRequest` return an error which misses each `if`
check, `CompareAndPullRequestPost` will return immediately, since it
doesn't write the HTTP response, a 200 response with empty body will be
sent to clients.

```go
	if err := pull_service.NewPullRequest(ctx, repo, pullIssue, labelIDs, attachments, pullRequest, assigneeIDs); err != nil {
		if repo_model.IsErrUserDoesNotHaveAccessToRepo(err) {
			ctx.Error(http.StatusBadRequest, "UserDoesNotHaveAccessToRepo", err.Error())
		} else if git.IsErrPushRejected(err) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, user_model.ErrBlockedUser) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, issues_model.ErrMustCollaborator) {
			// ...
			ctx.JSONError(flashError)
		}
		return
	}
```

Not sure what kind of error can cause it to happen, so this PR just
expose it. And we can fix it when users report that creating PRs failed
with error responses.

It's all my guess since I cannot reproduce the problem, but even if it's
not related, the code here needs to be improved.

Co-authored-by: Jason Song <i@wolfogre.com>
2024-08-16 13:50:12 -04:00
.devcontainer
.gitea
.github
assets
build
cmd
contrib
custom/conf
docker
docs
models Fix panic of ssh public key page after deletion of auth source (#31829) (#31836) 2024-08-16 01:50:57 +08:00
modules Fix IsObjectExist with gogit (#31790) (#31806) 2024-08-09 15:43:23 +08:00
options Fixes for unreachable project issues when transfer repository from organization (#31770) (#31828) 2024-08-14 09:57:23 +08:00
public
routers Avoid returning without written ctx when posting PR (#31843) (#31848) 2024-08-16 13:50:12 -04:00
services Fixes for unreachable project issues when transfer repository from organization (#31770) (#31828) 2024-08-14 09:57:23 +08:00
snap
templates Fixes for unreachable project issues when transfer repository from organization (#31770) (#31828) 2024-08-14 09:57:23 +08:00
tests Show lock owner instead of repo owner on LFS setting page (#31788) (#31817) 2024-08-11 15:17:34 +00:00
tools
web_src Scroll images in project issues separately from the remaining issue (#31683) (#31823) 2024-08-13 10:43:48 +08:00
.air.toml
.changelog.yml
.dockerignore
.editorconfig
.envrc Enable direnv (#31672) (#31679) 2024-07-23 11:35:28 -04:00
.eslintrc.yaml
.gitattributes
.gitignore Enable direnv (#31672) (#31679) 2024-07-23 11:35:28 -04:00
.gitpod.yml
.golangci.yml
.ignore
.markdownlint.yaml
.npmrc
.spectral.yaml
.yamllint.yaml
BSDmakefile
build.go
CHANGELOG-archived.md
CHANGELOG.md Add changelog for 1.22.1 (#31517) 2024-07-04 10:17:07 +08:00
CODE_OF_CONDUCT.md
CONTRIBUTING.md
crowdin.yml
DCO
Dockerfile Fix deprecated Dockerfile ENV format (#31450) (#31452) 2024-06-24 00:53:37 +00:00
Dockerfile.rootless Fix deprecated Dockerfile ENV format (#31450) (#31452) 2024-06-24 00:53:37 +00:00
flake.lock
flake.nix
go.mod fix redis deps (#31662) (#31663) 2024-07-19 20:14:58 +00:00
go.sum fix redis deps (#31662) (#31663) 2024-07-19 20:14:58 +00:00
LICENSE
main.go
MAINTAINERS
Makefile Add TAGS to TEST_TAGS and fix bugs found with gogit (#31791) (#31795) 2024-08-07 15:58:09 +00:00
package-lock.json Backport: Fix dates displaying in a wrong manner when we're close to the end of… (#31750) 2024-08-01 18:54:30 +00:00
package.json Backport: Fix dates displaying in a wrong manner when we're close to the end of… (#31750) 2024-08-01 18:54:30 +00:00
playwright.config.js
poetry.lock
poetry.toml
pyproject.toml
README.md
README_ZH.md
SECURITY.md
stylelint.config.js
tailwind.config.js
updates.config.js
vitest.config.js
webpack.config.js

Gitea

Contribute with Gitpod

View this document in Chinese

Purpose

The goal of this project is to make the easiest, fastest, and most painless way of setting up a self-hosted Git service.

As Gitea is written in Go, it works across all the platforms and architectures that are supported by Go, including Linux, macOS, and Windows on x86, amd64, ARM and PowerPC architectures. This project has been forked from Gogs since November of 2016, but a lot has changed.

For online demonstrations, you can visit demo.gitea.com.

For accessing free Gitea service (with a limited number of repositories), you can visit gitea.com.

To quickly deploy your own dedicated Gitea instance on Gitea Cloud, you can start a free trial at cloud.gitea.com.

Building

From the root of the source tree, run:

TAGS="bindata" make build

or if SQLite support is required:

TAGS="bindata sqlite sqlite_unlock_notify" make build

The build target is split into two sub-targets:

  • make backend which requires Go Stable, the required version is defined in go.mod.
  • make frontend which requires Node.js LTS or greater.

Internet connectivity is required to download the go and npm modules. When building from the official source tarballs which include pre-built frontend files, the frontend target will not be triggered, making it possible to build without Node.js.

More info: https://docs.gitea.com/installation/install-from-source

Using

./gitea web

Note

If you're interested in using our APIs, we have experimental support with documentation.

Contributing

Expected workflow is: Fork -> Patch -> Push -> Pull Request

Note

  1. YOU MUST READ THE CONTRIBUTORS GUIDE BEFORE STARTING TO WORK ON A PULL REQUEST.
  2. If you have found a vulnerability in the project, please write privately to security@gitea.io. Thanks!

Translating

Translations are done through Crowdin. If you want to translate to a new language ask one of the managers in the Crowdin project to add a new language there.

You can also just create an issue for adding a language or ask on discord on the #translation channel. If you need context or find some translation issues, you can leave a comment on the string or ask on Discord. For general translation questions there is a section in the docs. Currently a bit empty but we hope to fill it as questions pop up.

https://docs.gitea.com/contributing/localization

Crowdin

Further information

For more information and instructions about how to install Gitea, please look at our documentation. If you have questions that are not covered by the documentation, you can get in contact with us on our Discord server or create a post in the discourse forum.

We maintain a list of Gitea-related projects at gitea/awesome-gitea.

The official Gitea CLI is developed at gitea/tea.

Authors

Backers

Thank you to all our backers! 🙏 [Become a backer]

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]

FAQ

How do you pronounce Gitea?

Gitea is pronounced /ɡɪti:/ as in "gi-tea" with a hard g.

Why is this not hosted on a Gitea instance?

We're working on it.

License

This project is licensed under the MIT License. See the LICENSE file for the full license text.

Screenshots

Looking for an overview of the interface? Check it out!

Dashboard User Profile Global Issues
Branches Web Editor Activity
New Migration Migrating Pull Request View
Pull Request Dark Diff Review Dark Diff Dark