0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 13:14:48 +01:00
gitea/routers
SteveTheEngineer 1e2c2edab6
Catch the error before the response is processed by goth. (#20000)
The code introduced by #18185 gets the error from response after it was processed by goth.

That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
This fixes it by handling the error before the request is passed to goth.
2022-06-20 16:37:54 +01:00
..
api Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
common
install feat: add DEFAULT_MERGE_STYLE to repository.pull-request section for repo init (#19751) 2022-06-02 23:45:54 -04:00
private Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
utils
web Catch the error before the response is processed by goth. (#20000) 2022-06-20 16:37:54 +01:00
init.go Fix data-race problems in git module (quick patch) (#19934) 2022-06-11 11:56:27 +08:00