0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 06:55:00 +01:00
gitea/tests
Giteabot b8e6cffd31
Preserve BOM in web editor (#28935) (#28959)
Backport #28935 by @silverwind

The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.

Co-authored-by: silverwind <me@silverwind.io>
2024-01-27 23:23:31 +01:00
..
e2e Change green buttons to primary color (#27099) 2023-09-18 22:05:31 +00:00
fuzz Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
gitea-lfs-meta
gitea-repositories-meta Fix reverting a merge commit failing (#28794) (#28825) 2024-01-21 14:18:37 +00:00
integration Preserve BOM in web editor (#28935) (#28959) 2024-01-27 23:23:31 +01:00
testdata/data/attachments/a/0 Allow get release download files and lfs files with oauth2 token format (#26430) (#27379) 2023-10-01 19:54:11 +08:00
mssql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
mysql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
mysql8.ini.tmpl Do not use deprecated log config options by default (#26592) 2023-08-20 01:05:29 +00:00
pgsql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
sqlite.ini.tmpl Do not use deprecated log config options by default (#26592) 2023-08-20 01:05:29 +00:00
test_utils.go Allow get release download files and lfs files with oauth2 token format (#26430) (#27379) 2023-10-01 19:54:11 +08:00