0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 13:14:48 +01:00
gitea/modules/repository
zeripath 26ef180f46
Correctly rollback in ForkRepository (#17034)
The rollback functionality in
services/repository/repository.go:ForkRepository is incorrect and could
lead to a deadlock as it uses DeleteRepository to delete the rolled-back
repository - a function which creates its own transaction.

This PR adjusts the rollback function to only use RemoveAll as any
database changes will be automatically rolled-back. It also handles
panics and adjusts the Close within WithTx to ensure that if there is a
panic the session will always be closed.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-14 18:16:40 +02:00
..
adopt.go
archive.go
branch.go
cache.go
check.go
commits.go
commits_test.go
create.go
create_test.go
fork.go Correctly rollback in ForkRepository (#17034) 2021-09-14 18:16:40 +02:00
fork_test.go
generate.go
hooks.go
init.go
main_test.go
push.go
repo.go Add skip and limit to git.GetTags (#16897) 2021-09-10 19:30:37 +02:00
update.go