0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 16:04:24 +01:00
gitea/models/db
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
install
paginator
common.go Modify milestone search keywords to be case insensitive again (#20513) 2022-07-28 18:58:04 +02:00
consistency.go
context.go Fix various typos (#20338) 2022-07-12 23:32:37 +02:00
convert.go
engine.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
engine_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
index.go Refactor GetNextResourceIndex to make it work properly with transaction (#21469) 2022-10-16 18:44:16 +08:00
index_test.go Refactor GetNextResourceIndex to make it work properly with transaction (#21469) 2022-10-16 18:44:16 +08:00
iterate.go Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
list_options.go
log.go
main_test.go
name.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
search.go
sequence.go
sql_postgres_with_schema.go