0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-30 03:07:50 +01:00
gitea/models/issues
Kemal Zebari 242b331260
Prevent re-review and dismiss review actions on closed and merged PRs (#30065)
Resolves #29965.

---
Manually tested this by:
- Following the
[installation](https://docs.gitea.com/next/installation/install-with-docker#basics)
guide (but built a local Docker image instead)
- Creating 2 users, one who is the `Owner` of a newly-created repository
and the other a `Collaborator`
- Had the `Collaborator` create a PR that the `Owner` reviews
- `Collaborator` resolves conversation and `Owner` merges PR

And with this change we see that we can no longer see re-request review
button for the `Owner`:

<img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM"
src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4">
2024-03-28 15:19:24 +00:00
..
assignees.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
assignees_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
comment.go Do some performance optimize for issues list and view issue/pull (#29515) 2024-03-12 07:23:44 +00:00
comment_code.go Load attachments for code comments (#30124) 2024-03-27 04:44:26 +00:00
comment_list.go Do some performance optimize for issues list and view issue/pull (#29515) 2024-03-12 07:23:44 +00:00
comment_test.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
content_history.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
content_history_test.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
dependency.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
dependency_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue.go Performance improvements for pull request list page (#29900) 2024-03-21 14:13:08 +01:00
issue_index.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
issue_label.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_label_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_list.go Performance improvements for pull request list page (#29900) 2024-03-21 14:13:08 +01:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_lock.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_project.go Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
issue_search.go Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (#29990) 2024-03-24 18:51:08 +00:00
issue_stats.go Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (#29990) 2024-03-24 18:51:08 +00:00
issue_test.go Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
issue_update.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
issue_user.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
issue_user_test.go Fix bug with sqlite load read (#26305) 2023-08-05 10:40:27 +08:00
issue_watch.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_watch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_xref.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
issue_xref_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00
label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
label_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
milestone_list.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
milestone_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull.go Fix codeowner detected diff base branch to mergebase (#29783) 2024-03-15 05:13:09 +00:00
pull_list.go Refactor StringsToInt64s (#29967) 2024-03-21 15:07:35 +00:00
pull_test.go Refactor StringsToInt64s (#29967) 2024-03-21 15:07:35 +00:00
reaction.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
review.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
review_list.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
review_test.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
stopwatch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tracked_time.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
tracked_time_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00