0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-22 16:24:06 +01:00
gitea/services
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 21:09:51 +01:00
..
actions Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
agit Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
asymkey Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
attachment Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
auth Fix SSPI user creation (#28948) 2024-01-27 09:27:34 +00:00
automerge Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
context Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
convert Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
cron Update go dependencies (#28518) 2023-12-19 09:18:42 +08:00
doctor Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
externalaccount Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Remove trust model selection from repository creation on web page because it can be changed in settings later (#28814) 2024-01-16 20:54:48 +08:00
gitdiff Add option to disable ambiguous unicode characters detection (#28454) 2023-12-17 14:38:54 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
lfs Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
mailer Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
markup make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrations Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
mirror Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
notify Update status and code index after changing the default branch (#27018) 2023-09-13 04:43:31 +00:00
org Delete repos of org when purge delete user (#27273) 2023-10-19 13:16:11 +00:00
packages Fix some RPM registry flaws (#28782) 2024-01-19 11:37:10 +00:00
pull Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
release Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
repository Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Forbid removing the last admin user (#28337) 2024-01-15 06:51:43 +00:00
webhook Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
wiki Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00