0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 00:24:41 +01:00
gitea/cmd
zeripath dd12384f22
Fix --port setting (#13288)
* Fix --port setting

Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read

However, on looking further into this code I believe that the setPort
code was slightly odd.

Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.

Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart

Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration

(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)

Fix #13277

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update cmd/web.go

* Apply suggestions from code review

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-10-30 15:26:03 -04:00
..
admin.go
admin_auth_ldap.go
admin_auth_ldap_test.go
cert.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
cmd.go
convert.go Move database settings from models to setting (#7806) 2019-08-24 11:24:45 +02:00
doctor.go
dump.go
embedded.go
embedded_stub.go
generate.go
hook.go
keys.go
mailer.go
manager.go
migrate.go
migrate_storage.go
serv.go
web.go
web_graceful.go