mirror of
https://github.com/go-gitea/gitea
synced 2024-11-17 23:41:49 +01:00
191a74d622
The OAuth spec [defines two types of client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1), confidential and public. Previously Gitea assumed all clients to be confidential. > OAuth defines two client types, based on their ability to authenticate securely with the authorization server (i.e., ability to > maintain the confidentiality of their client credentials): > > confidential > Clients capable of maintaining the confidentiality of their credentials (e.g., client implemented on a secure server with > restricted access to the client credentials), or capable of secure client authentication using other means. > > **public > Clients incapable of maintaining the confidentiality of their credentials (e.g., clients executing on the device used by the resource owner, such as an installed native application or a web browser-based application), and incapable of secure client authentication via any other means.** > > The client type designation is based on the authorization server's definition of secure authentication and its acceptable exposure levels of client credentials. The authorization server SHOULD NOT make assumptions about the client type. https://datatracker.ietf.org/doc/html/rfc8252#section-8.4 > Authorization servers MUST record the client type in the client registration details in order to identify and process requests accordingly. Require PKCE for public clients: https://datatracker.ietf.org/doc/html/rfc8252#section-8.1 > Authorization servers SHOULD reject authorization requests from native apps that don't use PKCE by returning an error message Fixes #21299 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
55 lines
2.3 KiB
Handlebars
55 lines
2.3 KiB
Handlebars
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "settings.edit_oauth2_application"}}
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<p>{{.locale.Tr "settings.oauth2_application_create_description"}}</p>
|
|
</div>
|
|
<div class="ui attached segment form ignore-dirty">
|
|
{{.CsrfTokenHtml}}
|
|
<div class="field">
|
|
<label for="client-id">{{.locale.Tr "settings.oauth2_client_id"}}</label>
|
|
<input id="client-id" readonly value="{{.App.ClientID}}">
|
|
</div>
|
|
{{if .ClientSecret}}
|
|
<div class="field">
|
|
<label for="client-secret">{{.locale.Tr "settings.oauth2_client_secret"}}</label>
|
|
<input id="client-secret" type="text" readonly value="{{.ClientSecret}}">
|
|
</div>
|
|
{{else}}
|
|
<div class="field">
|
|
<label for="client-secret">{{.locale.Tr "settings.oauth2_client_secret"}}</label>
|
|
<input id="client-secret" type="password" readonly value="averysecuresecret">
|
|
</div>
|
|
{{end}}
|
|
<div class="item">
|
|
<!-- TODO add regenerate secret functionality */ -->
|
|
<form class="ui form ignore-dirty" action="{{.FormActionPath}}/regenerate_secret" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
{{.locale.Tr "settings.oauth2_regenerate_secret_hint"}}
|
|
<button class="ui tertiary button" type="submit">{{.locale.Tr "settings.oauth2_regenerate_secret"}}</button>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
<div class="ui attached bottom segment">
|
|
<form class="ui form ignore-dirty" action="{{.FormActionPath}}" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
<div class="field {{if .Err_AppName}}error{{end}}">
|
|
<label for="application-name">{{.locale.Tr "settings.oauth2_application_name"}}</label>
|
|
<input id="application-name" value="{{.App.Name}}" name="application_name" required>
|
|
</div>
|
|
<div class="field {{if .Err_RedirectURI}}error{{end}}">
|
|
<label for="redirect-uri">{{.locale.Tr "settings.oauth2_redirect_uri"}}</label>
|
|
<input type="url" name="redirect_uri" value="{{.App.PrimaryRedirectURI}}" id="redirect-uri">
|
|
</div>
|
|
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}">
|
|
<label>{{.locale.Tr "settings.oauth2_confidential_client"}}</label>
|
|
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
|
|
</div>
|
|
<button class="ui green button">
|
|
{{.locale.Tr "settings.save_application"}}
|
|
</button>
|
|
</form>
|
|
</div>
|
|
</div>
|