0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-19 08:22:44 +01:00
gitea/routers/api/v1/repo
Giteabot 571822b6ec
Fix issue dependencies (#27736) (#28776)
Backport #27736 by @lng2020

Fix #27722 
Fix #27357
Fix #25837 
Fix #28732 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
2024-01-12 23:29:22 +02:00
..
action.go Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
avatar.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
blob.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
branch.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-11 06:16:56 +00:00
collaborators.go More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
fork.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
git_hook.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
hook_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_attachment.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
issue_comment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_comment_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_dependency.go Fix issue dependencies (#27736) (#28776) 2024-01-12 23:29:22 +02:00
issue_label.go Don't let API add 2 exclusive labels from same scope (#27433) (#27460) 2023-10-06 05:06:31 +08:00
issue_pin.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
issue_reaction.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
issue_stopwatch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_subscription.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_tracked_time.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
key.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
label.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
migrate.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
milestone.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
mirror.go Add RemoteAddress to mirrors (#26952) 2023-09-16 16:03:02 +00:00
notes.go api: GetPullRequestCommits: return file list (#27483) (#27539) 2023-10-09 14:21:35 +02:00
patch.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
pull.go api: GetPullRequestCommits: return file list (#27483) (#27539) 2023-10-09 14:21:35 +02:00
pull_review.go More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
release.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
release_attachment.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
release_tags.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
repo.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
repo_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
star.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
status.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
subscriber.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
tag.go Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
teams.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
transfer.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tree.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
wiki.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00