0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-15 15:54:02 +01:00
gitea/models/fixtures
yp05327 daf2a4c047
Fix wrong display of recently pushed notification (#25812)
There's a bug in #25715: 
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.


![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1)
The latest commit is 2 weeks ago.

![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411)

The notification comes from another repo with same branch name:

![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252)


After:
In forked repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32)
New PR Link will redirect to the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786)
In the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df)

In the same repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf)

08/15 Update:
Follow #26257, added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203


2024/04/25 Update:
Fix #30611

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-21 17:00:35 +00:00
..
access.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
access_token.yml Fix more yaml lint errors (#27284) 2023-09-26 12:56:42 -04:00
action.yml Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) 2023-04-07 18:08:36 +08:00
action_run.yml Actions Artifacts v4 backend (#28965) 2024-03-02 09:12:17 +00:00
action_run_job.yml Actions Artifacts v4 backend (#28965) 2024-03-02 09:12:17 +00:00
action_runner_token.yml Add unit tests for action runner token (#27670) 2023-10-19 07:24:24 +00:00
action_task.yml Actions Artifacts v4 backend (#28965) 2024-03-02 09:12:17 +00:00
attachment.yml Allow get release download files and lfs files with oauth2 token format (#26430) 2023-10-01 10:41:52 +00:00
branch.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
collaboration.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
comment.yml Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
commit_status.yml
commit_status_index.yml Fix more yaml lint errors (#27284) 2023-09-26 12:56:42 -04:00
deploy_key.yml
email_address.yml Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
external_login_user.yml add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
follow.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
gpg_key.yml Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
gpg_key_import.yml
hook_task.yml Store webhook event in database (#29145) 2024-03-07 23:18:38 +01:00
issue.yml Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
issue_assignees.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
issue_index.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
issue_label.yml
issue_user.yml [API] ListIssues add more filters (#16174) 2021-06-16 18:33:37 -04:00
issue_watch.yml
label.yml Allow to archive labels (#26478) 2023-08-14 11:56:14 +02:00
lfs_meta_object.yml Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
login_source.yml
milestone.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
mirror.yml Fix bug of branches API with tests (#25578) 2023-07-01 10:52:52 +08:00
notice.yml
notification.yml
oauth2_application.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_authorization_code.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_grant.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
org_user.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
project.yml Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
project_board.yml Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
project_issue.yml Kanban board (#8346) 2020-08-16 23:07:38 -04:00
protected_branch.yml
protected_tag.yml Protected tag is no internal server error (#30962) 2024-05-14 06:48:21 +00:00
public_key.yml Fix more yaml lint errors (#27284) 2023-09-26 12:56:42 -04:00
pull_request.yml Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
reaction.yml Fix more yaml lint errors (#27284) 2023-09-26 12:56:42 -04:00
release.yml Allow get release download files and lfs files with oauth2 token format (#26430) 2023-10-01 10:41:52 +00:00
renamed_branch.yml Add a simple way to rename branch like gh (#15870) 2021-10-08 19:03:04 +02:00
repo_archiver.yml Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
repo_indexer_status.yml
repo_redirect.yml
repo_topic.yml
repo_transfer.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
repo_unit.yml Fix projects mode bugs (#29593) 2024-03-04 20:49:21 +00:00
repository.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
review.yml Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
star.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
stopwatch.yml
system_setting.yml Fix context cache bug & enable context cache for dashabord commits' authors (#26991) 2023-09-11 10:14:01 +00:00
team.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
team_repo.yml Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
team_unit.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
team_user.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
topic.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
tracked_time.yml
two_factor.yml
user.yml Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
user_blocking.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
user_open_id.yml
user_redirect.yml Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
watch.yml Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
webauthn_credential.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
webhook.yml Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00