0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-01-01 02:34:39 +01:00
gitea/templates/repo
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-04-25 22:53:44 -04:00
..
actions
branch
cite
diff
editor
find
graph
issue Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
migrate
projects
pulls
release Add tags list for repos whose release setting is disabled (#23465) 2023-04-25 18:29:00 +02:00
settings Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
tag Add tags list for repos whose release setting is disabled (#23465) 2023-04-25 18:29:00 +02:00
wiki
activity.tmpl Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
blame.tmpl
branch_dropdown.tmpl Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
clone_buttons.tmpl
clone_script.tmpl
commit_page.tmpl
commit_status.tmpl
commit_statuses.tmpl
commits.tmpl
commits_list.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
commits_list_small.tmpl
commits_table.tmpl
create.tmpl
create_helper.tmpl
empty.tmpl
file_info.tmpl
forks.tmpl
graph.tmpl
header.tmpl
home.tmpl Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
icon.tmpl
packages.tmpl
search.tmpl
search_name.tmpl
shabox_badge.tmpl
sub_menu.tmpl Add tags list for repos whose release setting is disabled (#23465) 2023-04-25 18:29:00 +02:00
sub_menu_release_tag.tmpl Add tags list for repos whose release setting is disabled (#23465) 2023-04-25 18:29:00 +02:00
unicode_escape_prompt.tmpl
upload.tmpl
user_cards.tmpl Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
view_file.tmpl Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
view_list.tmpl
watchers.tmpl