0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-24 19:34:35 +01:00
gitea/cmd
zeripath dd12384f22
Fix --port setting (#13288)
* Fix --port setting

Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read

However, on looking further into this code I believe that the setPort
code was slightly odd.

Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.

Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart

Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration

(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)

Fix #13277

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update cmd/web.go

* Apply suggestions from code review

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-10-30 15:26:03 -04:00
..
admin.go Sendmail command (#13079) 2020-10-24 16:38:14 -04:00
admin_auth_ldap.go
admin_auth_ldap_test.go
cert.go
cmd.go Sendmail command (#13079) 2020-10-24 16:38:14 -04:00
convert.go
doctor.go
dump.go
embedded.go
embedded_stub.go
generate.go
hook.go
keys.go
mailer.go Fix send mail (#13312) 2020-10-26 12:42:27 -04:00
manager.go
migrate.go
migrate_storage.go
serv.go
web.go Fix --port setting (#13288) 2020-10-30 15:26:03 -04:00
web_graceful.go Move install pages out of main macaron routes (#13195) 2020-10-19 17:03:08 -04:00