mirror of
https://github.com/go-gitea/gitea
synced 2024-11-25 14:42:47 +01:00
c1f76aea45
In Wiki pages, short-links created to local Wiki files were always expanded as regular Wiki Links. In particular, if a link wanted to point to a file that Gitea doesn't know how to render (e.g, a .zip file), a user following the link would be silently redirected to the Wiki's home page. This change makes short-links* in Wiki pages be expanded to raw wiki links, so these local wiki files may be accessed without manually accessing their URL. * only short-links ending in a file extension that isn't renderable are affected. Closes #27121. Signed-off-by: Rafael Girão <rafael.s.girao@tecnico.ulisboa.pt> Co-authored-by: silverwind <me@silverwind.io>
52 lines
1.5 KiB
Go
52 lines
1.5 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/url"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/util"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func assertFileExist(t *testing.T, p string) {
|
|
exist, err := util.IsExist(p)
|
|
assert.NoError(t, err)
|
|
assert.True(t, exist)
|
|
}
|
|
|
|
func assertFileEqual(t *testing.T, p string, content []byte) {
|
|
bs, err := os.ReadFile(p)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, content, bs)
|
|
}
|
|
|
|
func TestRepoCloneWiki(t *testing.T) {
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
dstPath := t.TempDir()
|
|
|
|
r := fmt.Sprintf("%suser2/repo1.wiki.git", u.String())
|
|
u, _ = url.Parse(r)
|
|
u.User = url.UserPassword("user2", userPassword)
|
|
t.Run("Clone", func(t *testing.T) {
|
|
assert.NoError(t, git.CloneWithArgs(context.Background(), git.AllowLFSFiltersArgs(), u.String(), dstPath, git.CloneRepoOptions{}))
|
|
assertFileEqual(t, filepath.Join(dstPath, "Home.md"), []byte("# Home page\n\nThis is the home page!\n"))
|
|
assertFileExist(t, filepath.Join(dstPath, "Page-With-Image.md"))
|
|
assertFileExist(t, filepath.Join(dstPath, "Page-With-Spaced-Name.md"))
|
|
assertFileExist(t, filepath.Join(dstPath, "images"))
|
|
assertFileExist(t, filepath.Join(dstPath, "files/Non-Renderable-File.zip"))
|
|
assertFileExist(t, filepath.Join(dstPath, "jpeg.jpg"))
|
|
})
|
|
})
|
|
}
|