mirror of
https://github.com/go-gitea/gitea
synced 2024-10-30 02:39:24 +01:00
59d060622d
Follow #22719 ### Major changes 1. `ServerError` doesn't do format, so remove the `%s` 2. Simplify `RenderBranchFeed` (slightly) 3. Remove unused `BranchFeedRSS` 4. Make `feed.RenderBranchFeed` respect `EnableFeed` config 5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting, otherwise there is always RSS icon 6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem right for all cases, for example, the string `src` could appear in `branchURLPrefix`, so we need a separate `rssURLPrefix` 7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself would be triggered at the same time 8. Change `<a><button></button></a>` to `<a role=button>` 9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v := .TreeNames}}/{{$v}}{{end}}` Screenshot of changed parts: <details> ![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png) ![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png) ![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png) </details> ### Other thoughts Should we remove the RSS icon from the branch dropdown list? It seems too complex for a list UI, and users already have the chance to get the RSS feed URL from "branches" page. --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: silverwind <me@silverwind.io>
56 lines
1.4 KiB
Go
56 lines
1.4 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package feed
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"github.com/gorilla/feeds"
|
|
)
|
|
|
|
// ShowFileFeed shows tags and/or releases on the repo as RSS / Atom feed
|
|
func ShowFileFeed(ctx *context.Context, repo *repo.Repository, formatType string) {
|
|
fileName := ctx.Repo.TreePath
|
|
if len(fileName) == 0 {
|
|
return
|
|
}
|
|
commits, err := ctx.Repo.GitRepo.CommitsByFileAndRange(ctx.Repo.RefName, fileName, 1)
|
|
if err != nil {
|
|
ctx.ServerError("ShowBranchFeed", err)
|
|
return
|
|
}
|
|
|
|
title := fmt.Sprintf("Latest commits for file %s", ctx.Repo.TreePath)
|
|
|
|
link := &feeds.Link{Href: repo.HTMLURL() + "/" + ctx.Repo.BranchNameSubURL() + "/" + util.PathEscapeSegments(ctx.Repo.TreePath)}
|
|
|
|
feed := &feeds.Feed{
|
|
Title: title,
|
|
Link: link,
|
|
Description: repo.Description,
|
|
Created: time.Now(),
|
|
}
|
|
|
|
for _, commit := range commits {
|
|
feed.Items = append(feed.Items, &feeds.Item{
|
|
Id: commit.ID.String(),
|
|
Title: strings.TrimSpace(strings.Split(commit.Message(), "\n")[0]),
|
|
Link: &feeds.Link{Href: repo.HTMLURL() + "/commit/" + commit.ID.String()},
|
|
Author: &feeds.Author{
|
|
Name: commit.Author.Name,
|
|
Email: commit.Author.Email,
|
|
},
|
|
Description: commit.Message(),
|
|
Content: commit.Message(),
|
|
})
|
|
}
|
|
|
|
writeFeed(ctx, feed, formatType)
|
|
}
|