mirror of
https://github.com/go-gitea/gitea
synced 2024-11-30 00:57:49 +01:00
ea1d09718c
It is not correct to return tag data when commit data is requested, so remove the hacky code that overwrote parts of a commit with parts of a tag. This fixes commit retrieval by tag for both the latest commit in the UI and the commit info on tag webhook events. Fixes: https://github.com/go-gitea/gitea/issues/21687 Replaces: https://github.com/go-gitea/gitea/pull/21693 <img width="324" alt="Screenshot 2022-11-13 at 15 26 37" src="https://user-images.githubusercontent.com/115237/201526975-736c6ea7-ad6a-467a-a823-9a63d6ecb718.png"> <img width="789" alt="image" src="https://user-images.githubusercontent.com/115237/201526876-90a13ffc-1e5c-4d76-911b-f1ae51e8eaab.png"> --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
55 lines
1.4 KiB
Go
55 lines
1.4 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRepository_GetRefs(t *testing.T) {
|
|
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
|
|
bareRepo1, err := openRepositoryWithDefaultContext(bareRepo1Path)
|
|
assert.NoError(t, err)
|
|
defer bareRepo1.Close()
|
|
|
|
refs, err := bareRepo1.GetRefs()
|
|
|
|
assert.NoError(t, err)
|
|
assert.Len(t, refs, 6)
|
|
|
|
expectedRefs := []string{
|
|
BranchPrefix + "branch1",
|
|
BranchPrefix + "branch2",
|
|
BranchPrefix + "master",
|
|
TagPrefix + "test",
|
|
TagPrefix + "signed-tag",
|
|
NotesRef,
|
|
}
|
|
|
|
for _, ref := range refs {
|
|
assert.Contains(t, expectedRefs, ref.Name)
|
|
}
|
|
}
|
|
|
|
func TestRepository_GetRefsFiltered(t *testing.T) {
|
|
bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
|
|
bareRepo1, err := openRepositoryWithDefaultContext(bareRepo1Path)
|
|
assert.NoError(t, err)
|
|
defer bareRepo1.Close()
|
|
|
|
refs, err := bareRepo1.GetRefsFiltered(TagPrefix)
|
|
|
|
assert.NoError(t, err)
|
|
if assert.Len(t, refs, 2) {
|
|
assert.Equal(t, TagPrefix+"signed-tag", refs[0].Name)
|
|
assert.Equal(t, "tag", refs[0].Type)
|
|
assert.Equal(t, "36f97d9a96457e2bab511db30fe2db03893ebc64", refs[0].Object.String())
|
|
assert.Equal(t, TagPrefix+"test", refs[1].Name)
|
|
assert.Equal(t, "tag", refs[1].Type)
|
|
assert.Equal(t, "3ad28a9149a2864384548f3d17ed7f38014c9e8a", refs[1].Object.String())
|
|
}
|
|
}
|