mirror of
https://github.com/go-gitea/gitea
synced 2024-11-25 06:42:49 +01:00
de484e86bc
This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
82 lines
3 KiB
Go
82 lines
3 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unit"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/util"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIRepoTeams(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// publicOrgRepo = user3/repo21
|
|
publicOrgRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 32})
|
|
// user4
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
session := loginUser(t, user.Name)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo)
|
|
|
|
// ListTeams
|
|
url := fmt.Sprintf("/api/v1/repos/%s/teams?token=%s", publicOrgRepo.FullName(), token)
|
|
req := NewRequest(t, "GET", url)
|
|
res := MakeRequest(t, req, http.StatusOK)
|
|
var teams []*api.Team
|
|
DecodeJSON(t, res, &teams)
|
|
if assert.Len(t, teams, 2) {
|
|
assert.EqualValues(t, "Owners", teams[0].Name)
|
|
assert.True(t, teams[0].CanCreateOrgRepo)
|
|
assert.True(t, util.SliceSortedEqual(unit.AllUnitKeyNames(), teams[0].Units), fmt.Sprintf("%v == %v", unit.AllUnitKeyNames(), teams[0].Units))
|
|
assert.EqualValues(t, "owner", teams[0].Permission)
|
|
|
|
assert.EqualValues(t, "test_team", teams[1].Name)
|
|
assert.False(t, teams[1].CanCreateOrgRepo)
|
|
assert.EqualValues(t, []string{"repo.issues"}, teams[1].Units)
|
|
assert.EqualValues(t, "write", teams[1].Permission)
|
|
}
|
|
|
|
// IsTeam
|
|
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "Test_Team", token)
|
|
req = NewRequest(t, "GET", url)
|
|
res = MakeRequest(t, req, http.StatusOK)
|
|
var team *api.Team
|
|
DecodeJSON(t, res, &team)
|
|
assert.EqualValues(t, teams[1], team)
|
|
|
|
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "NonExistingTeam", token)
|
|
req = NewRequest(t, "GET", url)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
// AddTeam with user4
|
|
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
|
|
req = NewRequest(t, "PUT", url)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
|
|
// AddTeam with user2
|
|
user = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
session = loginUser(t, user.Name)
|
|
token = getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo)
|
|
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
|
|
req = NewRequest(t, "PUT", url)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
|
|
|
|
// DeleteTeam
|
|
url = fmt.Sprintf("/api/v1/repos/%s/teams/%s?token=%s", publicOrgRepo.FullName(), "team1", token)
|
|
req = NewRequest(t, "DELETE", url)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
MakeRequest(t, req, http.StatusUnprocessableEntity) // test duplicate request
|
|
}
|