0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 23:15:34 +01:00
gitea/models
Lauris BH 6e64f9db8e Pull request review/approval and comment on code (#3748)
* Initial ui components for pull request review

* Add Review
Add IssueComment types

Signed-off-by: Jonas Franz <info@jonasfranz.software>

(cherry picked from commit 2b4daab)
Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Replace ReviewComment with Content

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add load functions
Add ReviewID to findComments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add create review comment implementation
Add migration for review
Other small changes

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Simplified create and find functions for review

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Moved "Pending" to first position

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add GetCurrentReview to simplify fetching current review

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Preview for listing comments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Move new comment form to its own file

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Implement Review form
Show Review comments on comment stream

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for single comments
Showing buttons in context

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add pending tag to pending review comments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add unit tests for Review

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fetch all review ids at once
Add unit tests

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* gofmt

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Improved comment rendering in "Files" view by adding Comments to DiffLine

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for invalidating comments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Switched back to code.gitea.io/git

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Moved review migration from v64 to v65

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Rebuild css

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* gofmt

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Improve translations

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix unit tests by updating fixtures and updating outdated test

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Comments will be shown at the right place now

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for deleting CodeComments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix problems caused by files in subdirectories

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for showing code comments of reviews in conversation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for "Show/Hide outdated"

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Update code.gitea.io/git

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add support for new webhooks

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Update comparison

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Resolve conflicts

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Minor UI improvements

* update code.gitea.io/git

* Fix ui bug reported by @lunny causing wrong position of add button
Add functionality to "Cancel" button
Add scale effects to add button
Hide "Cancel" button for existing comments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Prepare solving conflicts

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Show add button only if no comments already exist for the line

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add missing vendor files

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Check if reviewer is nil

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Show forms only to users who are logged in

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Revert "Show forms only to users who are logged in"

This reverts commit c083682

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Save patch in comment
Render patch for code comments

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add link to comment in code

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add reply form to comment list
Show forms only to signed in users

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add 'Reply' as translatable
Add CODE_COMMENT_LINES setting

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* gofmt

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix problems introduced by checking for singed in user

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add v70

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Update generated stylesheet

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix preview
Beginn with new review comment patch system

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add new algo to generate diff for line range
Remove old algo used for cutting big diffs (it was very buggy)

* Add documentation and example for CutDiffAroundLine

* Fix example of CutDiffAroundLine

* Fix some comment UI rendering bugs

* Add code comment edit mode

* Send notifications / actions to users until review gets published
Fix diff generation bug
Fix wrong hashtag

* Fix vet errors

* Send notifications also for single comments

* Fix some notification bugs, fix link

* Fix: add comment icon is only shown on code lines

* Add lint comment

* Add unit tests for git diff

* Add more error messages

* Regenerated css

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* fmt

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Regenerated CSS with latest less version

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix test by updating comment type to new ID

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Introducing CodeComments as type for map[string]map[int64][]*Comment
Other minor code improvements

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Fix data-tab issues

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Remove unnecessary change

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* refactored checkForInvalidation

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Append comments instead of setting

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Use HeadRepo instead of BaseRepo

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Update migration

Signed-off-by: Jonas Franz <info@jonasfranz.de>

* Regenerated CSS

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Add copyright

Signed-off-by: Jonas Franz <info@jonasfranz.software>

* Update index.css

Signed-off-by: Jonas Franz <info@jonasfranz.software>
2018-08-06 06:43:21 +02:00
..
fixtures Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
migrations Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
access.go
access_test.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
action.go Added dependencies for issues (#2196) (#2531) 2018-07-17 17:23:58 -04:00
action_list.go refactor: reduce sql query in retrieveFeeds (#3547) 2018-02-21 18:55:34 +08:00
action_test.go fix: Add feed for organization (#3594) 2018-03-03 13:21:16 +08:00
admin.go
admin_test.go
attachment.go Add Size column to attachment (#3734) 2018-03-31 09:10:44 +08:00
attachment_test.go Add Attachment API (#3478) 2018-03-06 09:22:16 +08:00
branches.go Fix incorrect MergeWhitelistTeamIDs check in CanUserMerge function (#4519) (#4525) 2018-07-27 22:11:24 +03:00
branches_test.go
consistency.go
error.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
error_oauth2.go
external_login_user.go
git_diff.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
git_diff_test.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
gpg_key.go Don't write to log NoCommitterAccount (#3621) 2018-03-04 10:45:01 +08:00
gpg_key_test.go
graph.go Make max commits in graph configurable (#4498) 2018-07-23 17:12:06 +03:00
graph_test.go Accept 'Data:' in commit graph (#4487) 2018-07-21 14:17:09 -04:00
helper.go
issue.go Update xorm to latest version and fix correct user table referencing in sql (#4473) 2018-07-20 10:10:17 +08:00
issue_assignees.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
issue_assignees_test.go Multiple assignees (#3705) 2018-05-09 19:29:04 +03:00
issue_comment.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
issue_comment_test.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
issue_dependency.go Added dependencies for issues (#2196) (#2531) 2018-07-17 17:23:58 -04:00
issue_dependency_test.go Added dependencies for issues (#2196) (#2531) 2018-07-17 17:23:58 -04:00
issue_indexer.go Reduce repo indexer disk usage (#3452) 2018-02-05 20:29:17 +02:00
issue_label.go Add label descriptions (#3662) 2018-03-13 10:03:55 +08:00
issue_label_test.go
issue_list.go fix bugs when too many IN variables (#4594) 2018-08-02 21:49:05 +08:00
issue_list_test.go Shows total tracked time in issue and milestone list (#3341) 2018-04-29 13:58:47 +08:00
issue_mail.go Multiple assignees (#3705) 2018-05-09 19:29:04 +03:00
issue_milestone.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
issue_milestone_test.go Add more webhooks support and refactor webhook templates directory (#3929) 2018-05-16 22:01:55 +08:00
issue_reaction.go
issue_reaction_test.go
issue_stopwatch.go Shows total tracked time in issue and milestone list (#3341) 2018-04-29 13:58:47 +08:00
issue_stopwatch_test.go
issue_test.go Shows total tracked time in issue and milestone list (#3341) 2018-04-29 13:58:47 +08:00
issue_tracked_time.go Shows total tracked time in issue and milestone list (#3341) 2018-04-29 13:58:47 +08:00
issue_tracked_time_test.go
issue_user.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
issue_user_test.go Multiple assignees (#3705) 2018-05-09 19:29:04 +03:00
issue_watch.go Update xorm to latest version and fix correct user table referencing in sql (#4473) 2018-07-20 10:10:17 +08:00
issue_watch_test.go
lfs.go
lfs_lock.go Fix SSH auth lfs locks (#3152) 2018-01-27 18:48:15 +02:00
login_source.go
mail.go
main_test.go
models.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
models_sqlite.go
models_test.go Change parsing of postgresql settings (#4275) 2018-06-20 08:06:01 +03:00
notification.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
notification_test.go
oauth2.go Store OAuth2 session data in database (#3660) 2018-04-29 09:09:24 +03:00
org.go Fix out-of-transaction query in removeOrgUser (#4521) (#4522) 2018-07-27 02:41:36 +03:00
org_team.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
org_team_test.go
org_test.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
pull.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
pull_test.go
release.go fix bug when deleting a release (#4207) 2018-06-12 12:44:17 -04:00
repo.go Update xorm to latest version and fix correct user table referencing in sql (#4473) 2018-07-20 10:10:17 +08:00
repo_activity.go Add issue closed time column to fix activity closed issues list (#3537) 2018-02-19 10:39:26 +08:00
repo_branch.go
repo_collaboration.go Fix not removed watches on unallowed repositories (#4201) 2018-06-19 15:44:33 -04:00
repo_collaboration_test.go
repo_editor.go
repo_indexer.go Update code.gitea.io/git (#3482) 2018-02-10 20:19:26 +02:00
repo_issue.go Add EnableTimetracking option to app settings (#3719) 2018-04-09 23:15:32 +08:00
repo_list.go Added repository search ordered by stars or forks. Forks column in admin repo list. (#3969) 2018-05-24 09:03:42 +08:00
repo_list_test.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
repo_mirror.go fix: if Mirrors repo no content is fetched, updated time should not b… (#3551) 2018-02-22 18:27:09 -06:00
repo_redirect.go
repo_redirect_test.go
repo_test.go
repo_unit.go Added dependencies for issues (#2196) (#2531) 2018-07-17 17:23:58 -04:00
repo_watch.go Update xorm to latest version and fix correct user table referencing in sql (#4473) 2018-07-20 10:10:17 +08:00
repo_watch_test.go
review.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
review_test.go Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
ssh_key.go LDAP Public SSH Keys synchronization (#1844) 2018-05-24 07:59:02 +03:00
ssh_key_test.go
star.go
star_test.go
status.go
status_test.go
test_fixtures.go
token.go
token_test.go
topic.go Fixed violation of the unique constraint for v68 migration (#4297) 2018-06-27 01:23:10 -04:00
topic_test.go Fix topics addition (Another solution) (#4031) (#4258) 2018-06-21 17:09:46 +08:00
twofactor.go Switch plaintext scratch tokens to use hash instead (#4331) 2018-07-27 08:54:50 -04:00
u2f.go Add support for FIDO U2F (#3971) 2018-05-19 17:12:37 +03:00
u2f_test.go Add support for FIDO U2F (#3971) 2018-05-19 17:12:37 +03:00
unit.go
unit_tests.go Use unique temp dirs in unit tests (#3494) 2018-02-21 01:38:52 -06:00
update.go env var GITEA_PUSHER_EMAIL (#4516) 2018-07-26 19:38:55 +03:00
update_test.go
user.go Update xorm to latest version and fix correct user table referencing in sql (#4473) 2018-07-20 10:10:17 +08:00
user_follow.go
user_follow_test.go
user_mail.go
user_mail_test.go
user_openid.go
user_openid_test.go
user_test.go hide issues from org private repos w/o team assignment (#4034) 2018-06-21 12:00:13 -04:00
webhook.go fix webhook bug of response info is not displayed in UI (#4000) 2018-05-23 14:12:02 +08:00
webhook_dingtalk.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
webhook_discord.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
webhook_slack.go Fix some webhooks bugs (#3981) 2018-05-21 10:28:29 +08:00
webhook_test.go Add more webhooks support and refactor webhook templates directory (#3929) 2018-05-16 22:01:55 +08:00
wiki.go Fix to use only needed columns from tables to get repository git paths (#3870) 2018-05-02 09:10:19 +03:00
wiki_test.go test: reduce testing time. (#3885) 2018-05-02 21:56:19 +08:00