mirror of
https://github.com/go-gitea/gitea
synced 2024-08-15 06:44:55 +02:00
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
170 lines
5.2 KiB
Go
170 lines
5.2 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package web
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/go-chi/chi"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRoute1(t *testing.T) {
|
|
buff := bytes.NewBufferString("")
|
|
recorder := httptest.NewRecorder()
|
|
recorder.Body = buff
|
|
|
|
r := NewRoute()
|
|
r.Get("/{username}/{reponame}/{type:issues|pulls}", func(resp http.ResponseWriter, req *http.Request) {
|
|
username := chi.URLParam(req, "username")
|
|
assert.EqualValues(t, "gitea", username)
|
|
reponame := chi.URLParam(req, "reponame")
|
|
assert.EqualValues(t, "gitea", reponame)
|
|
tp := chi.URLParam(req, "type")
|
|
assert.EqualValues(t, "issues", tp)
|
|
})
|
|
|
|
req, err := http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
}
|
|
|
|
func TestRoute2(t *testing.T) {
|
|
buff := bytes.NewBufferString("")
|
|
recorder := httptest.NewRecorder()
|
|
recorder.Body = buff
|
|
|
|
var route int
|
|
|
|
r := NewRoute()
|
|
r.Group("/{username}/{reponame}", func() {
|
|
r.Group("", func() {
|
|
r.Get("/{type:issues|pulls}", func(resp http.ResponseWriter, req *http.Request) {
|
|
username := chi.URLParam(req, "username")
|
|
assert.EqualValues(t, "gitea", username)
|
|
reponame := chi.URLParam(req, "reponame")
|
|
assert.EqualValues(t, "gitea", reponame)
|
|
tp := chi.URLParam(req, "type")
|
|
assert.EqualValues(t, "issues", tp)
|
|
route = 0
|
|
})
|
|
|
|
r.Get("/{type:issues|pulls}/{index}", func(resp http.ResponseWriter, req *http.Request) {
|
|
username := chi.URLParam(req, "username")
|
|
assert.EqualValues(t, "gitea", username)
|
|
reponame := chi.URLParam(req, "reponame")
|
|
assert.EqualValues(t, "gitea", reponame)
|
|
tp := chi.URLParam(req, "type")
|
|
assert.EqualValues(t, "issues", tp)
|
|
index := chi.URLParam(req, "index")
|
|
assert.EqualValues(t, "1", index)
|
|
route = 1
|
|
})
|
|
}, func(resp http.ResponseWriter, req *http.Request) {
|
|
resp.WriteHeader(200)
|
|
})
|
|
|
|
r.Group("/issues/{index}", func() {
|
|
r.Get("/view", func(resp http.ResponseWriter, req *http.Request) {
|
|
username := chi.URLParam(req, "username")
|
|
assert.EqualValues(t, "gitea", username)
|
|
reponame := chi.URLParam(req, "reponame")
|
|
assert.EqualValues(t, "gitea", reponame)
|
|
index := chi.URLParam(req, "index")
|
|
assert.EqualValues(t, "1", index)
|
|
route = 2
|
|
})
|
|
})
|
|
})
|
|
|
|
req, err := http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 0, route)
|
|
|
|
req, err = http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues/1", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 1, route)
|
|
|
|
req, err = http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues/1/view", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 2, route)
|
|
}
|
|
|
|
func TestRoute3(t *testing.T) {
|
|
buff := bytes.NewBufferString("")
|
|
recorder := httptest.NewRecorder()
|
|
recorder.Body = buff
|
|
|
|
var route int
|
|
|
|
m := NewRoute()
|
|
r := NewRoute()
|
|
r.Mount("/api/v1", m)
|
|
|
|
m.Group("/repos", func() {
|
|
m.Group("/{username}/{reponame}", func() {
|
|
m.Group("/branch_protections", func() {
|
|
m.Get("", func(resp http.ResponseWriter, req *http.Request) {
|
|
route = 0
|
|
})
|
|
m.Post("", func(resp http.ResponseWriter, req *http.Request) {
|
|
route = 1
|
|
})
|
|
m.Group("/{name}", func() {
|
|
m.Get("", func(resp http.ResponseWriter, req *http.Request) {
|
|
route = 2
|
|
})
|
|
m.Patch("", func(resp http.ResponseWriter, req *http.Request) {
|
|
route = 3
|
|
})
|
|
m.Delete("", func(resp http.ResponseWriter, req *http.Request) {
|
|
route = 4
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
req, err := http.NewRequest("GET", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 0, route)
|
|
|
|
req, err = http.NewRequest("POST", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code, http.StatusOK)
|
|
assert.EqualValues(t, 1, route)
|
|
|
|
req, err = http.NewRequest("GET", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 2, route)
|
|
|
|
req, err = http.NewRequest("PATCH", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 3, route)
|
|
|
|
req, err = http.NewRequest("DELETE", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
|
|
assert.NoError(t, err)
|
|
r.ServeHTTP(recorder, req)
|
|
assert.EqualValues(t, http.StatusOK, recorder.Code)
|
|
assert.EqualValues(t, 4, route)
|
|
}
|