sillyguodong 2f49b55c19 Fix cannot reopen after pushing commits to a closed PR (#23189) ... Close: #22784 1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of [issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which needs to be fixed. 2. After closing a PR and pushing commits, `headBranchSha` is not equal to `sha`(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.  3. Even if PR is already close, we should still insert comment record into DB when we push commits. So we should still call function `CreatePushPullComment()`. 067b0c2664/services/pull/pull.go (L260-L282) So, I add a switch(`includeClosed`) to the `GetUnmergedPullRequestsByHeadInfo` func to control whether the status of PR must be open. In this case, by setting `includeClosed` to `true`, we can query the closed PR.  4. In the loop of comments, I use the`latestCloseCommentID` variable to record the last occurrence of the close comment. In the go template, if the status of PR is closed, the comments whose type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID` won't be rendered.  e.g. 1). The initial status of the PR is opened.  2). Then I click the button of `Close`. PR is closed now.  3). I try to push a commit to this PR, even though its current status is closed.  But in comments list, this commit do not display.This is as expected ：）  4). Click the `Reopen` button, the commit which is pushed after closing PR display now.  --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2023-03-03 21:16:58 +08:00
..
actions	Require approval to run actions for fork pull request (#22803)	2023-02-24 15:58:49 +08:00
agit	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00
asymkey	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
attachment	Add API management for issue/pull and comment attachments (#21783)	2022-12-09 14:35:56 +08:00
auth	Use minio/sha256-simd for accelerated SHA256 (#23052)	2023-02-22 14:21:46 -05:00
automerge	Add force_merge to merge request and fix checking mergable (#23010)	2023-02-21 08:42:07 -06:00
context	Support org/user level projects (#22235)	2023-01-20 19:42:33 +08:00
convert	Fix SyncOnCommit always return false in API of push_mirrors (#23088)	2023-02-23 15:50:33 -06:00
cron	Add Cargo package registry (#21888)	2023-02-05 18:12:31 +08:00
externalaccount
forms	Add force_merge to merge request and fix checking mergable (#23010)	2023-02-21 08:42:07 -06:00
gitdiff	Refactor git command package to improve security and maintainability (#22678)	2023-02-04 10:30:43 +08:00
issue	Webhooks: for issue close/reopen action, add commit ID that caused it (#22583)	2023-01-24 23:47:53 -05:00
lfs	Use minio/sha256-simd for accelerated SHA256 (#23052)	2023-02-22 14:21:46 -05:00
mailer	Use minio/sha256-simd for accelerated SHA256 (#23052)	2023-02-22 14:21:46 -05:00
markup
migrations	Add loading yaml label template files (#22976)	2023-03-02 01:44:23 +02:00
mirror	Use proxy for pull mirror (#22771)	2023-02-11 08:39:50 +08:00
org
packages	Use import of OCI structs (#22765)	2023-02-06 10:07:09 +00:00
pull	Fix cannot reopen after pushing commits to a closed PR (#23189)	2023-03-03 21:16:58 +08:00
release	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
repository	Use context parameter in services/repository (#23186)	2023-02-28 16:17:51 -06:00
task
user	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
webhook	Use minio/sha256-simd for accelerated SHA256 (#23052)	2023-02-22 14:21:46 -05:00
wiki	Improve utils of slices (#22379)	2023-01-11 13:31:16 +08:00