0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-06-16 01:19:34 +02:00
gitea/models
Jason Song 82728a7cec
Do not overwrite empty DefaultBranch (#22708)
Fix #21994. 
And fix #19470.

While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".


19d5b2f922/modules/repository/generate.go (L241-L253)

Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:


19d5b2f922/models/repo/repo.go (L228-L233)

I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)

I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 14:48:48 -06:00
..
actions Fix ref to trigger Actions (#22679) 2023-01-31 22:45:25 +00:00
activities Don't return duplicated users who can create org repo (#22560) 2023-01-30 18:12:45 +08:00
admin Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
asymkey Improve error report when user passes a private key (#22726) 2023-02-02 18:25:54 +00:00
auth Support scoped access tokens (#20908) 2023-01-17 15:46:03 -06:00
avatars Fix get system setting bug when enabled redis cache (#22295) 2023-01-02 00:06:52 +08:00
db some refactor about code comments (#20821) 2023-01-17 15:03:44 -06:00
dbfs Add some comments for recent code (#22725) 2023-02-02 11:39:38 -06:00
fixtures Do not overwrite empty DefaultBranch (#22708) 2023-02-02 14:48:48 -06:00
git Add cron method to gc LFS MetaObjects (#22385) 2023-01-16 13:50:53 -06:00
issues Small refactor for loading PRs (#22652) 2023-02-01 21:49:28 -06:00
migrations Implement actions (#21937) 2023-01-31 09:45:19 +08:00
organization Don't return duplicated users who can create org repo (#22560) 2023-01-30 18:12:45 +08:00
packages Add Conda package registry (#22262) 2023-02-01 12:30:39 -06:00
perm Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
project Project links should use parent link methods (#22587) 2023-01-23 15:51:18 -06:00
pull refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo Do not overwrite empty DefaultBranch (#22708) 2023-02-02 14:48:48 -06:00
secret Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
system Set disable_gravatar/enable_federated_avatar when offline mode is true (#22479) 2023-01-17 17:00:19 +02:00
unit Implement actions (#21937) 2023-01-31 09:45:19 +08:00
unittest Implement actions (#21937) 2023-01-31 09:45:19 +08:00
user Implement actions (#21937) 2023-01-31 09:45:19 +08:00
webhook Support system hook API (#14537) 2023-01-28 19:12:10 +01:00
error.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_generation.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrate.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
migrate_test.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
org.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
org_team.go Supports wildcard protected branch (#20825) 2023-01-16 16:00:22 +08:00
org_team_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
repo_collaboration.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo_collaboration_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_transfer.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
repo_transfer_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
user.go Supports wildcard protected branch (#20825) 2023-01-16 16:00:22 +08:00