0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 10:05:05 +01:00
gitea/services/pull
zeripath 8354670708
Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991)
This PR contains multiple fixes. The most important of which is:

* Prevent hang in git cat-file if the repository is not a valid repository 
    
    Unfortunately it appears that if git cat-file is run in an invalid
    repository it will hang until stdin is closed. This will result in
    deadlocked /pulls pages and dangling git cat-file calls if a broken
    repository is tried to be reviewed or pulls exists for a broken
    repository.

    Fix #14734
    Fix #9271
    Fix #16113

Otherwise there are a few small other fixes included which this PR was initially intending to fix:

* Fix panic on partial compares due to missing PullRequestWorkInProgressPrefixes
* Fix links on pulls pages  due to regression from #17551 - by making most /issues routes match /pulls too - Fix #17983
* Fix links on feeds pages due to another regression from #17551 but also fix issue with syncing tags - Fix #17943
* Add missing locale entries for oauth group claims
* Prevent NPEs if ColorFormat is called on nil users, repos or teams.
2021-12-16 19:01:14 +00:00
..
check.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
check_test.go Decouple unit test, remove intermediate unittestbridge package (#17662) 2021-11-16 16:53:21 +08:00
commit_status.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
lfs.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
main_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
merge.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
patch.go Move unit into models/unit/ (#17576) 2021-11-09 20:57:58 +01:00
pull.go Prevent hang in git cat-file if repository is not a valid repository and other fixes (#17991) 2021-12-16 19:01:14 +00:00
pull_test.go
review.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
temp_repo.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
update.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00