0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-25 15:02:56 +01:00
gitea/routers/api/v1
Zettat123 898f852d03
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397)
Backport #32365

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.


348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img
width="600px"

src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
2024-11-01 03:53:59 +00:00
..
activitypub Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
admin Fix empty field login_name in API response JSON when creating user (#30511) 2024-04-16 13:13:00 +08:00
misc Fix missing images in editor preview due to wrong links (#31299) (#31393) 2024-06-17 15:07:21 +08:00
notify Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
org Fix bug when a token is given public only (#32204) (#32218) 2024-10-09 02:16:37 +00:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
repo Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
settings Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
shared Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
swagger feat(api): implement branch/commit comparison API (#30349) 2024-04-16 11:45:04 +08:00
user Fix bug when a token is given public only (#32204) (#32218) 2024-10-09 02:16:37 +00:00
utils Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
api.go Fix the permission check for user search API and limit the number of returned users for /user/search (#32310) 2024-10-23 04:56:13 +00:00