0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-21 23:11:05 +01:00
gitea/services
Zettat123 898f852d03
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397)
Backport #32365

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.


348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img
width="600px"

src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
2024-11-01 03:53:59 +00:00
..
actions Update scheduled tasks even if changes are pushed by "ActionsUser" (#32246) (#32252) 2024-10-14 16:55:16 +08:00
agit Performance optimization for git push (#30104) 2024-04-09 03:43:17 +00:00
asymkey Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
attachment Add support for API blob upload of release attachments (#29507) 2024-03-02 17:02:01 +00:00
auth Don't init singing keys if oauth2 provider disabled (#32177) 2024-10-03 11:34:56 -04:00
automerge Fix agit automerge (#31207) (#31881) 2024-08-20 16:20:58 +00:00
context Fix bug when a token is given public only (#32204) (#32218) 2024-10-09 02:16:37 +00:00
contexttest Check if reverse proxy is correctly configured (#30890) (#30935) 2024-05-10 12:34:04 +00:00
convert Fix /repos/{owner}/{repo}/pulls/{index}/files endpoint not populating previous_filename (#32017) (#32028) 2024-09-12 08:58:43 +09:00
cron Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
doctor Add a db consistency check to remove runners that do not belong to a repository (#30614) 2024-04-23 03:51:52 +00:00
externalaccount [Fix] Account Linking UpdateMigrationsByType (#31428) (#31434) 2024-06-20 13:53:15 +00:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Fix: Allow org team names of length 255 in create team form (#31564) (#31603) 2024-07-10 12:28:27 -04:00
gitdiff Refactor sha1 and time-limited code (#31023) (#31030) 2024-05-21 00:58:21 +08:00
indexer Update issue indexer after merging a PR (#30715) (#30903) 2024-05-09 13:51:57 +08:00
issue Fix 500 error when state params is set when editing issue/PR by API (#31880) (#31952) 2024-09-01 18:38:10 +00:00
lfs Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
mailer Add missing comment reply handling (#32050) (#32065) 2024-09-18 09:23:28 +00:00
markup Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
migrations Support allowed hosts for migrations to work with proxy (#32025) (#32026) 2024-09-11 14:54:19 +08:00
mirror Remove unused parameter for some functions in services/mirror (#30724) 2024-04-27 10:44:49 +00:00
notify Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
org Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
packages Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
pull Fix the logic of finding the latest pull review commit ID (#32139) (#32165) 2024-10-01 13:10:03 +09:00
release Handle invalid target when creating releases using API (#31841) (#32043) 2024-09-17 02:23:40 +00:00
repository Fix bug when deleting a migrated branch (#32075) (#32123) 2024-09-24 17:01:05 +08:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix "force private" logic (#31012) (#31021) 2024-05-20 10:27:52 +08:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Add warn log when deleting inactive users (#32318) (#32321) 2024-10-23 10:48:42 +08:00
webhook Truncate commit message during Discord webhook push events (#31970) (#32121) 2024-09-24 13:28:01 +08:00
webtheme Initial support for colorblindness-friendly themes (#30625) 2024-04-24 00:18:41 +08:00
wiki Avoid showing Failed to change the default wiki branch if repo has no wiki when saving repo settings (#30329) 2024-04-08 19:43:23 +08:00