mirror of
https://github.com/go-gitea/gitea
synced 2024-11-18 16:01:36 +01:00
722a7c902d
In investigating #7947 it has become clear that the storage component of go-git repositories needs closing. This PR adds this Close function and adds the Close functions as necessary. In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files. Fixes #7947
220 lines
6.8 KiB
Go
220 lines
6.8 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repofiles
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
models.MainTest(m, filepath.Join("..", ".."))
|
|
}
|
|
|
|
func getExpectedReadmeContentsResponse() *api.ContentsResponse {
|
|
treePath := "README.md"
|
|
sha := "4b4851ad51df6a7d9f25c979345979eaeb5b349f"
|
|
encoding := "base64"
|
|
content := "IyByZXBvMQoKRGVzY3JpcHRpb24gZm9yIHJlcG8x"
|
|
selfURL := "https://try.gitea.io/api/v1/repos/user2/repo1/contents/" + treePath + "?ref=master"
|
|
htmlURL := "https://try.gitea.io/user2/repo1/src/branch/master/" + treePath
|
|
gitURL := "https://try.gitea.io/api/v1/repos/user2/repo1/git/blobs/" + sha
|
|
downloadURL := "https://try.gitea.io/user2/repo1/raw/branch/master/" + treePath
|
|
return &api.ContentsResponse{
|
|
Name: treePath,
|
|
Path: treePath,
|
|
SHA: "4b4851ad51df6a7d9f25c979345979eaeb5b349f",
|
|
Type: "file",
|
|
Size: 30,
|
|
Encoding: &encoding,
|
|
Content: &content,
|
|
URL: &selfURL,
|
|
HTMLURL: &htmlURL,
|
|
GitURL: &gitURL,
|
|
DownloadURL: &downloadURL,
|
|
Links: &api.FileLinksResponse{
|
|
Self: &selfURL,
|
|
GitURL: &gitURL,
|
|
HTMLURL: &htmlURL,
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestGetContents(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
treePath := "README.md"
|
|
ref := ctx.Repo.Repository.DefaultBranch
|
|
|
|
expectedContentsResponse := getExpectedReadmeContentsResponse()
|
|
|
|
t.Run("Get README.md contents with GetContents()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContents(ctx.Repo.Repository, treePath, ref, false)
|
|
assert.EqualValues(t, expectedContentsResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("Get REAMDE.md contents with ref as empty string (should then use the repo's default branch) with GetContents()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContents(ctx.Repo.Repository, treePath, "", false)
|
|
assert.EqualValues(t, expectedContentsResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestGetContentsOrListForDir(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
treePath := "" // root dir
|
|
ref := ctx.Repo.Repository.DefaultBranch
|
|
|
|
readmeContentsResponse := getExpectedReadmeContentsResponse()
|
|
// because will be in a list, doesn't have encoding and content
|
|
readmeContentsResponse.Encoding = nil
|
|
readmeContentsResponse.Content = nil
|
|
|
|
expectedContentsListResponse := []*api.ContentsResponse{
|
|
readmeContentsResponse,
|
|
}
|
|
|
|
t.Run("Get root dir contents with GetContentsOrList()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContentsOrList(ctx.Repo.Repository, treePath, ref)
|
|
assert.EqualValues(t, expectedContentsListResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("Get root dir contents with ref as empty string (should then use the repo's default branch) with GetContentsOrList()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContentsOrList(ctx.Repo.Repository, treePath, "")
|
|
assert.EqualValues(t, expectedContentsListResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestGetContentsOrListForFile(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
treePath := "README.md"
|
|
ref := ctx.Repo.Repository.DefaultBranch
|
|
|
|
expectedContentsResponse := getExpectedReadmeContentsResponse()
|
|
|
|
t.Run("Get README.md contents with GetContentsOrList()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContentsOrList(ctx.Repo.Repository, treePath, ref)
|
|
assert.EqualValues(t, expectedContentsResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("Get REAMDE.md contents with ref as empty string (should then use the repo's default branch) with GetContentsOrList()", func(t *testing.T) {
|
|
fileContentResponse, err := GetContentsOrList(ctx.Repo.Repository, treePath, "")
|
|
assert.EqualValues(t, expectedContentsResponse, fileContentResponse)
|
|
assert.Nil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestGetContentsErrors(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
repo := ctx.Repo.Repository
|
|
treePath := "README.md"
|
|
ref := repo.DefaultBranch
|
|
|
|
t.Run("bad treePath", func(t *testing.T) {
|
|
badTreePath := "bad/tree.md"
|
|
fileContentResponse, err := GetContents(repo, badTreePath, ref, false)
|
|
assert.Error(t, err)
|
|
assert.EqualError(t, err, "object does not exist [id: , rel_path: bad]")
|
|
assert.Nil(t, fileContentResponse)
|
|
})
|
|
|
|
t.Run("bad ref", func(t *testing.T) {
|
|
badRef := "bad_ref"
|
|
fileContentResponse, err := GetContents(repo, treePath, badRef, false)
|
|
assert.Error(t, err)
|
|
assert.EqualError(t, err, "object does not exist [id: "+badRef+", rel_path: ]")
|
|
assert.Nil(t, fileContentResponse)
|
|
})
|
|
}
|
|
|
|
func TestGetContentsOrListErrors(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
repo := ctx.Repo.Repository
|
|
treePath := "README.md"
|
|
ref := repo.DefaultBranch
|
|
|
|
t.Run("bad treePath", func(t *testing.T) {
|
|
badTreePath := "bad/tree.md"
|
|
fileContentResponse, err := GetContentsOrList(repo, badTreePath, ref)
|
|
assert.Error(t, err)
|
|
assert.EqualError(t, err, "object does not exist [id: , rel_path: bad]")
|
|
assert.Nil(t, fileContentResponse)
|
|
})
|
|
|
|
t.Run("bad ref", func(t *testing.T) {
|
|
badRef := "bad_ref"
|
|
fileContentResponse, err := GetContentsOrList(repo, treePath, badRef)
|
|
assert.Error(t, err)
|
|
assert.EqualError(t, err, "object does not exist [id: "+badRef+", rel_path: ]")
|
|
assert.Nil(t, fileContentResponse)
|
|
})
|
|
}
|
|
|
|
func TestGetContentsOrListOfEmptyRepos(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo15")
|
|
ctx.SetParams(":id", "15")
|
|
test.LoadRepo(t, ctx, 15)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
repo := ctx.Repo.Repository
|
|
|
|
t.Run("empty repo", func(t *testing.T) {
|
|
contents, err := GetContentsOrList(repo, "", "")
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, contents)
|
|
})
|
|
}
|