mirror of
https://github.com/go-gitea/gitea
synced 2024-11-25 15:02:56 +01:00
3fe1f73268
Backport #31825 by @Zettat123 Fix #31395 This regression is introduced by #30273. To find out how GitHub handles this case, I did [some tests](https://github.com/go-gitea/gitea/issues/31395#issuecomment-2278929115). I use redirect in this PR instead of checking if the corresponding `.md` file exists when rendering the link because GitHub also uses redirect. With this PR, there is no need to resolve the raw wiki link when rendering a wiki page. If a wiki link points to a raw file, access will be redirected to the raw link. --------- Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
274 lines
9.1 KiB
Go
274 lines
9.1 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/gitrepo"
|
|
"code.gitea.io/gitea/modules/web"
|
|
"code.gitea.io/gitea/services/contexttest"
|
|
"code.gitea.io/gitea/services/forms"
|
|
wiki_service "code.gitea.io/gitea/services/wiki"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
content = "Wiki contents for unit tests"
|
|
message = "Wiki commit message for unit tests"
|
|
)
|
|
|
|
func wikiEntry(t *testing.T, repo *repo_model.Repository, wikiName wiki_service.WebPath) *git.TreeEntry {
|
|
wikiRepo, err := gitrepo.OpenWikiRepository(git.DefaultContext, repo)
|
|
assert.NoError(t, err)
|
|
defer wikiRepo.Close()
|
|
commit, err := wikiRepo.GetBranchCommit("master")
|
|
assert.NoError(t, err)
|
|
entries, err := commit.ListEntries()
|
|
assert.NoError(t, err)
|
|
for _, entry := range entries {
|
|
if entry.Name() == wiki_service.WebPathToGitPath(wikiName) {
|
|
return entry
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func wikiContent(t *testing.T, repo *repo_model.Repository, wikiName wiki_service.WebPath) string {
|
|
entry := wikiEntry(t, repo, wikiName)
|
|
if !assert.NotNil(t, entry) {
|
|
return ""
|
|
}
|
|
reader, err := entry.Blob().DataAsync()
|
|
assert.NoError(t, err)
|
|
defer reader.Close()
|
|
bytes, err := io.ReadAll(reader)
|
|
assert.NoError(t, err)
|
|
return string(bytes)
|
|
}
|
|
|
|
func assertWikiExists(t *testing.T, repo *repo_model.Repository, wikiName wiki_service.WebPath) {
|
|
assert.NotNil(t, wikiEntry(t, repo, wikiName))
|
|
}
|
|
|
|
func assertWikiNotExists(t *testing.T, repo *repo_model.Repository, wikiName wiki_service.WebPath) {
|
|
assert.Nil(t, wikiEntry(t, repo, wikiName))
|
|
}
|
|
|
|
func assertPagesMetas(t *testing.T, expectedNames []string, metas any) {
|
|
pageMetas, ok := metas.([]PageMeta)
|
|
if !assert.True(t, ok) {
|
|
return
|
|
}
|
|
if !assert.Len(t, pageMetas, len(expectedNames)) {
|
|
return
|
|
}
|
|
for i, pageMeta := range pageMetas {
|
|
assert.EqualValues(t, expectedNames[i], pageMeta.Name)
|
|
}
|
|
}
|
|
|
|
func TestWiki(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki")
|
|
ctx.SetParams("*", "Home")
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
Wiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, "Home", ctx.Data["Title"])
|
|
assertPagesMetas(t, []string{"Home", "Page With Image", "Page With Spaced Name", "Unescaped File"}, ctx.Data["Pages"])
|
|
|
|
ctx, _ = contexttest.MockContext(t, "user2/repo1/jpeg.jpg")
|
|
ctx.SetParams("*", "jpeg.jpg")
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
Wiki(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
assert.Equal(t, "/user2/repo1/wiki/raw/jpeg.jpg", ctx.Resp.Header().Get("Location"))
|
|
}
|
|
|
|
func TestWikiPages(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/?action=_pages")
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
WikiPages(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assertPagesMetas(t, []string{"Home", "Page With Image", "Page With Spaced Name", "Unescaped File"}, ctx.Data["Pages"])
|
|
}
|
|
|
|
func TestNewWiki(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/?action=_new")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
NewWiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, ctx.Tr("repo.wiki.new_page"), ctx.Data["Title"])
|
|
}
|
|
|
|
func TestNewWikiPost(t *testing.T) {
|
|
for _, title := range []string{
|
|
"New page",
|
|
"&&&&",
|
|
} {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/?action=_new")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &forms.NewWikiForm{
|
|
Title: title,
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
NewWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
assertWikiExists(t, ctx.Repo.Repository, wiki_service.UserTitleToWebPath("", title))
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, wiki_service.UserTitleToWebPath("", title)), content)
|
|
}
|
|
}
|
|
|
|
func TestNewWikiPost_ReservedName(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/?action=_new")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &forms.NewWikiForm{
|
|
Title: "_edit",
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
NewWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, ctx.Tr("repo.wiki.reserved_page", "_edit"), ctx.Flash.ErrorMsg)
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "_edit")
|
|
}
|
|
|
|
func TestEditWiki(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/Home?action=_edit")
|
|
ctx.SetParams("*", "Home")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
EditWiki(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assert.EqualValues(t, "Home", ctx.Data["Title"])
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, "Home"), ctx.Data["content"])
|
|
|
|
ctx, _ = contexttest.MockContext(t, "user2/repo1/wiki/jpeg.jpg?action=_edit")
|
|
ctx.SetParams("*", "jpeg.jpg")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
EditWiki(ctx)
|
|
assert.EqualValues(t, http.StatusForbidden, ctx.Resp.Status())
|
|
}
|
|
|
|
func TestEditWikiPost(t *testing.T) {
|
|
for _, title := range []string{
|
|
"Home",
|
|
"New/<page>",
|
|
} {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/Home?action=_new")
|
|
ctx.SetParams("*", "Home")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &forms.NewWikiForm{
|
|
Title: title,
|
|
Content: content,
|
|
Message: message,
|
|
})
|
|
EditWikiPost(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
assertWikiExists(t, ctx.Repo.Repository, wiki_service.UserTitleToWebPath("", title))
|
|
assert.Equal(t, wikiContent(t, ctx.Repo.Repository, wiki_service.UserTitleToWebPath("", title)), content)
|
|
if title != "Home" {
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "Home")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeleteWikiPagePost(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/Home?action=_delete")
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
DeleteWikiPagePost(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
assertWikiNotExists(t, ctx.Repo.Repository, "Home")
|
|
}
|
|
|
|
func TestWikiRaw(t *testing.T) {
|
|
for filepath, filetype := range map[string]string{
|
|
"jpeg.jpg": "image/jpeg",
|
|
"images/jpeg.jpg": "image/jpeg",
|
|
"files/Non-Renderable-File.zip": "application/octet-stream",
|
|
"Page With Spaced Name": "text/plain; charset=utf-8",
|
|
"Page-With-Spaced-Name": "text/plain; charset=utf-8",
|
|
"Page With Spaced Name.md": "", // there is no "Page With Spaced Name.md" in repo
|
|
"Page-With-Spaced-Name.md": "text/plain; charset=utf-8",
|
|
} {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/raw/"+url.PathEscape(filepath))
|
|
ctx.SetParams("*", filepath)
|
|
contexttest.LoadUser(t, ctx, 2)
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
WikiRaw(ctx)
|
|
if filetype == "" {
|
|
assert.EqualValues(t, http.StatusNotFound, ctx.Resp.Status(), "filepath: %s", filepath)
|
|
} else {
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status(), "filepath: %s", filepath)
|
|
assert.EqualValues(t, filetype, ctx.Resp.Header().Get("Content-Type"), "filepath: %s", filepath)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDefaultWikiBranch(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
|
|
// repo with no wiki
|
|
repoWithNoWiki := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
assert.False(t, repoWithNoWiki.HasWiki())
|
|
assert.NoError(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repoWithNoWiki, "main"))
|
|
|
|
// repo with wiki
|
|
assert.NoError(t, repo_model.UpdateRepositoryCols(db.DefaultContext, &repo_model.Repository{ID: 1, DefaultWikiBranch: "wrong-branch"}))
|
|
|
|
ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki")
|
|
ctx.SetParams("*", "Home")
|
|
contexttest.LoadRepo(t, ctx, 1)
|
|
assert.Equal(t, "wrong-branch", ctx.Repo.Repository.DefaultWikiBranch)
|
|
Wiki(ctx) // after the visiting, the out-of-sync database record will update the branch name to "master"
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.Equal(t, "master", ctx.Repo.Repository.DefaultWikiBranch)
|
|
|
|
// invalid branch name should fail
|
|
assert.Error(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "the bad name"))
|
|
repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.Equal(t, "master", repo.DefaultWikiBranch)
|
|
|
|
// the same branch name, should succeed (actually a no-op)
|
|
assert.NoError(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "master"))
|
|
repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.Equal(t, "master", repo.DefaultWikiBranch)
|
|
|
|
// change to another name
|
|
assert.NoError(t, wiki_service.ChangeDefaultWikiBranch(db.DefaultContext, repo, "main"))
|
|
repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.Equal(t, "main", repo.DefaultWikiBranch)
|
|
}
|