0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-03-15 05:32:31 +01:00
gitea/models
Jason Song a35714372d
Fix halfCommitter and WithTx (#22366)
Related to #22362.

I overlooked that there's always `committer.Close()`, like:

```go
		ctx, committer, err := db.TxContext(db.DefaultContext)
		if err != nil {
			return nil
		}
		defer committer.Close()

		// ...

		if err != nil {
			return nil
		}

		// ...

		return committer.Commit()
```

So the `Close` of `halfCommitter` should ignore `commit and close`, it's
not a rollback.

See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or
commit
LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612).

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-01-09 12:19:19 -05:00
..
activities Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
admin
asymkey
auth
avatars Fix get system setting bug when enabled redis cache (#22295) 2023-01-02 00:06:52 +08:00
db Fix halfCommitter and WithTx (#22366) 2023-01-09 12:19:19 -05:00
fixtures Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
git Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
issues Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
migrations
organization
packages
perm
project Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
pull
repo Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
secret
system Fix set system setting failure once it cached (#22333) 2023-01-08 21:22:41 +08:00
unit
unittest
user Fix get system setting bug when enabled redis cache (#22295) 2023-01-02 00:06:52 +08:00
webhook Remove old HookEventType (#22358) 2023-01-06 19:49:14 +08:00
error.go
fixture_generation.go
fixture_test.go
main_test.go
migrate.go
migrate_test.go
org.go
org_team.go
org_team_test.go
org_test.go
repo.go
repo_collaboration.go
repo_collaboration_test.go
repo_test.go
repo_transfer.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
repo_transfer_test.go
user.go