mirror of
https://github.com/go-gitea/gitea
synced 2024-12-28 13:34:24 +01:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
82 lines
3 KiB
Handlebars
82 lines
3 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content admin notice">
|
|
{{template "admin/navbar" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "admin.notices.system_notice_list"}} ({{.locale.Tr "admin.total" .Total}})
|
|
</h4>
|
|
<div class="ui attached table segment">
|
|
<table id="notice-table" class="ui very basic select selectable table unstackable">
|
|
<thead>
|
|
<tr>
|
|
<th></th>
|
|
<th>ID</th>
|
|
<th>{{.locale.Tr "admin.notices.type"}}</th>
|
|
<th>{{.locale.Tr "admin.notices.desc"}}</th>
|
|
<th width="100px">{{.locale.Tr "admin.users.created"}}</th>
|
|
<th>{{.locale.Tr "admin.notices.op"}}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{range .Notices}}
|
|
<tr>
|
|
<td class="collapsing">
|
|
<div class="ui fitted checkbox" data-id="{{.ID}}">
|
|
<input type="checkbox">
|
|
</div>
|
|
</td>
|
|
<td>{{.ID}}</td>
|
|
<td>{{$.locale.Tr .TrStr}}</td>
|
|
<td class="view-detail"><span class="notice-description text truncate">{{.Description}}</span></td>
|
|
<td><span class="notice-created-time tooltip" data-content="{{.CreatedUnix.AsTime}}"><time data-format="short-date" datetime="{{.CreatedUnix.FormatLong}}">{{.CreatedUnix.FormatShort}}</time></span></td>
|
|
<td><a href="#">{{svg "octicon-note" 16 "view-detail"}}</a></td>
|
|
</tr>
|
|
{{end}}
|
|
</tbody>
|
|
{{if .Notices}}
|
|
<tfoot class="full-width">
|
|
<tr>
|
|
<th></th>
|
|
<th colspan="5">
|
|
<form class="ui right" method="post" action="{{AppSubUrl}}/admin/notices/empty">
|
|
{{.CsrfTokenHtml}}
|
|
<button type="submit" class="ui red small button">{{.locale.Tr "admin.notices.delete_all"}}</button>
|
|
</form>
|
|
<div class="ui floating upward dropdown small button">{{/* TODO: Make this dropdown accessible */}}
|
|
<span class="text">{{.locale.Tr "admin.notices.operations"}}</span>
|
|
<div class="menu">
|
|
<div class="item select action" data-action="select-all">
|
|
{{.locale.Tr "admin.notices.select_all"}}
|
|
</div>
|
|
<div class="item select action" data-action="deselect-all">
|
|
{{.locale.Tr "admin.notices.deselect_all"}}
|
|
</div>
|
|
<div class="item select action" data-action="inverse">
|
|
{{.locale.Tr "admin.notices.inverse_selection"}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<button class="ui small teal button" id="delete-selection" data-link="{{.Link}}/delete" data-redirect="{{.Link}}?page={{.Page.Paginater.Current}}">
|
|
{{.locale.Tr "admin.notices.delete_selected"}}
|
|
</button>
|
|
</th>
|
|
</tr>
|
|
</tfoot>
|
|
{{end}}
|
|
</table>
|
|
</div>
|
|
|
|
{{template "base/paginate" .}}
|
|
</div>
|
|
</div>
|
|
|
|
<div class="ui modal admin" id="detail-modal">
|
|
{{svg "octicon-x" 16 "close inside"}}
|
|
<div class="header">{{$.locale.Tr "admin.notices.view_detail_header"}}</div>
|
|
<div class="content">
|
|
<div class="sub header"></div>
|
|
<pre></pre>
|
|
</div>
|
|
</div>
|
|
{{template "base/footer" .}}
|